Implement RPC calls in Jupyter/Colab #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- push + pull_request always triggers two builds - the secret is not available for non-contributors, resulting in bad builds every time
boa/rpc.py
Outdated
| @@ -54,7 +55,24 @@ def from_json(cls, data): | |||
| return cls(message=data["message"], code=data["code"]) | |||
|
|
|||
|
|
|||
| class EthereumRPC: | |||
| class RPC(ABC): | |||
There was a problem hiding this comment.
i have some bad memories about ABC / abstractmethod performance. can we make it simpler?
There was a problem hiding this comment.
I can remove the abc or remove the base class completely for duck typing
DanielSchiavini
force-pushed
the
119/browser-rpc
branch
from
cc4b11b
to
1528a3e
Compare
This was referenced Feb 5, 2024
DanielSchiavini
added a commit
to DanielSchiavini/titanoboa
that referenced
this pull request
Feb 5, 2024
boa/integrations/jupyter/browser.py
Outdated
| Create a BrowserSigner instance. | ||
| :param address: The account address. If not provided, it will be requested from the browser. | ||
| """ | ||
| if address: |
There was a problem hiding this comment.
Suggested change
| if address: | |
| if address is not None: |
boa/integrations/jupyter/browser.py
Outdated
| if method == "eth_getTransactionReceipt": | ||
| # we do the polling in the browser to avoid too many callbacks | ||
| # each callback generates currently 10px empty space in the frontend | ||
| timeout_ms = CALLBACK_TOKEN_TIMEOUT.total_seconds() * 1000 |
There was a problem hiding this comment.
let's use a separate constant for this
There was a problem hiding this comment.
e.g., WAIT_TRANSACTION_RECEIPT_TIMEOUT
boa/integrations/jupyter/jupyter.js
Outdated
| console.log(`Callback ${token} => ${responseText}`); | ||
| const body = stringify(await parsePromise(func(...args))); | ||
| // console.log(`Boa: ${func.name}(${args.map(a => JSON.stringify(a)).join(',')}) = ${body};`); | ||
| return colab ? body : callbackAPI(token, body); |
There was a problem hiding this comment.
i think we shouldn't return anything, since the return values of the two branches mean different things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
Depends on #132
What I did
Extended the interface with the browser to support RPC calls.
How I did it
It includes two new classes on the python side:
BrowserRpccalls the browser when a RPC call is madeboa.set_browser()combinesBrowserRpcandBrowserSignertogether to allow the environment to be used in boaboa.set_network(url)works as an alternative toboa.set_env(NetworkEnv(url))The JavaScript uses this method from ethers.js.
Tests are included, but unfortunately I had to mock all jupyter and tornado dependencies - they aren't installed in boa normally.
How to verify it
Install this branch and then run in Jupyter or Google Colab:
boa.env.eoashould return your wallet address.boa.env.get_gas_price()returns the current gas price.Description for the changelog
boa.set_browser()interface to interact with the browser wallet RPC in JupyterLabCute Animal Picture