Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RPC via browser wallet #119

Closed
charles-cooper opened this issue Jan 16, 2024 · 1 comment · Fixed by #124
Closed

Implement RPC via browser wallet #119

charles-cooper opened this issue Jan 16, 2024 · 1 comment · Fixed by #124

Comments

@charles-cooper
Copy link
Member 

          it would be cool to get the RPC url from the browser signer (h/t @bout3fiddy for the idea), but out of scope here. will open a new issue for it

Originally posted by @charles-cooper in #109 (comment)
@DanielSchiavini
Copy link
Collaborator

We could not figure out a way to get the RPC URL from the frontend, it might be hidden for security purposes (it often contains API keys).
An alternative would be to introduce a separate BrowserEnv that implements NetworkEnv via the browser

DanielSchiavini added a commit that referenced this issue Jan 24, 2024
@DanielSchiavini
Implement RPC calls via the browser
21008ef 
Fixes #119
@DanielSchiavini DanielSchiavini mentioned this issue Jan 24, 2024
Merged
@DanielSchiavini DanielSchiavini changed the title get RPC url from the browser signer Implement RPC via browser wallet Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement RPC calls in Jupyter/Colab vyperlang/titanoboa
2 participants
@DanielSchiavini @charles-cooper