Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign typed data using BrowserSigner #130

Merged

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Feb 5, 2024

Closes #128
Depends on #124

What I did

Allow signing typed data using BrowserSigner

How I did it

  • Created the sign_typed_data method in the BrowserSigner.
  • Created the signTypedData front-end callback
  • Added a test

How to verify it

Try in a notebook:

!pip install git+https://github.com/DanielSchiavini/titanoboa.git@128/sign-typed-data
from boa.integrations.jupyter import BrowserSigner
BrowserSigner().sign_typed_data(....)

Description for the changelog

Allow signing typed data in JupyterLab/Colab using BrowserSigner

Cute Animal Picture

image

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a UX perspective, it might be nice to have a browser_signer property on the NetworkEnv (which throws an error if the rpc is not a BrowserRPC).

@DanielSchiavini DanielSchiavini deleted the branch vyperlang:master February 7, 2024 15:26
@DanielSchiavini DanielSchiavini changed the base branch from 119/browser-rpc to master February 7, 2024 15:30
@DanielSchiavini
Copy link
Collaborator Author

@charles-cooper your comment is fixed in #131
There are no changes necessary in this branch, so I did not merge it here yet

@charles-cooper charles-cooper merged commit ec4270c into vyperlang:master Feb 8, 2024
6 of 11 checks passed
@DanielSchiavini DanielSchiavini deleted the 128/sign-typed-data branch February 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign typed data using browsersigner
2 participants