Set chain ID via BrowserSigner + #137 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boa/integrations/jupyter/browser.py
Outdated
| "rpc", "eth_chainId", timeout_message=RPC_TIMEOUT_MESSAGE | ||
| ) | ||
|
|
||
| @chain_id.setter |
There was a problem hiding this comment.
let's call this set_chain_id()
This reverts commit db8f14a.
DanielSchiavini
changed the title
+inline method since it's only called once
| """ | ||
|
|
||
| def __init__(self, address=None): | ||
| super().__init__(rpc=BrowserRPC()) |
There was a problem hiding this comment.
nit -- BrowserRPC() could have side effects, i'd personally put it on its own line --
rpc = BrowserRPC()
super().__init__(rpc=rpc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
Depends on
#124Includes #137
What I did
Set chain ID via BrowserSigner
How I did it
chain_idto BrowserSigner, with getter and setterHow to verify it
In jupyterlab
Description for the changelog
Allow retrieving and changing chain ID in JupyterLab/Colab via BrowserEnv
Cute Animal Picture