Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RPC calls in Jupyter/Colab #124
Implement RPC calls in Jupyter/Colab #124
Changes from 31 commits
21008ef
7aaf694
53804fe
a31c6f5
59c4715
15b4034
a2f2a2c
1126dd8
635dbfa
0aa4ae7
c9d808d
9021e3b
31911c3
07c9c06
1c07f82
ccbd823
cca9696
59db7d0
9d1e5c6
d396243
e1ae7e0
d9e9274
35e80d1
a32809d
65d557f
5b58f95
73f8b2f
e3a4b19
2847d10
1528a3e
9735953
dc6ab80
acbb919
0bf0348
41ec1db
b50a099
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use a separate constant for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g.,
WAIT_TRANSACTION_RECEIPT_TIMEOUT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we shouldn't return anything, since the return values of the two branches mean different things