-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework remaining errors #344
Rework remaining errors #344
Conversation
80cd3b5
to
5c44660
Compare
b5c36c9
to
a87c01a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small changes – most of the comments here are things we should defer to a cleanup PR so we can land this one and not block other things any longer.
Updated to address most of the comments, still investigating passing an owned |
Closes #296
Closes #298
Closes #299
Closes #300
Closes #305
Closes #343
Info
fs
module led to updating many of the other modules.Changes
fs
module to not use.unknown()
but instead return anio::Error
, as they are still IO utilities.distro
module to convert.unknown()
into.with_context()
hook
module to convert.unknown()
into.with_context()
inventory
module to convert.unknown()
into.with_context()
toolchain
module to convert.unknown()
into.with_context()
Notes
path.to_string_lossy().to_string()
to convert aPath
/PathBuf
to a string. I'm not sure the best approach to refactor that to prevent having that same block appear in multiple places.