Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a constant for common CTAs in ErrorDetails #343

Closed
charlespierce opened this issue Apr 8, 2019 · 0 comments · Fixed by #344
Closed

Use a constant for common CTAs in ErrorDetails #343

charlespierce opened this issue Apr 8, 2019 · 0 comments · Fixed by #344

Comments

@charlespierce
Copy link
Contributor

In updating the errors to all include nicer error messages, several of them have turned out to use the same CTA (by far the most common is a CTA about permissions for file system errors). These CTAs should be put into a constant and just referenced in each error message, so that we don't have a bunch of duplication in the strings.

This should be done after all of the .unknown() work has been reviewed and merged, so that the CTAs can be updated all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant