Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notion install fails if the same version has already been installed #352

Closed
charlespierce opened this issue Apr 15, 2019 · 2 comments · Fixed by #368
Closed

notion install fails if the same version has already been installed #352

charlespierce opened this issue Apr 15, 2019 · 2 comments · Fixed by #368
Assignees

Comments

@charlespierce
Copy link
Contributor

After running notion install <package> once, if it is run again and the same version is found, the install will show an error on this line: https://github.com/notion-cli/notion/blob/cd37603b3f78e5bfbf4af7a40e52e7ced1463b0d/crates/notion-core/src/distro/package.rs#L168

Since the image directory is not empty. We should detect that the requested version is already installed and not attempt to re-install the same package. Related to #288

@thoov
Copy link
Member

thoov commented Apr 17, 2019

@charlespierce To add to this. It also returns the following error:

  Unpacking ember-cli-v3.9.0  [========================================] 100%
error: an internal error occurred

Notion is still a pre-alpha project, so we expect to run into some bugs,
but we'd love to hear about them so we can fix them!

Please feel free to reach out to us at @notionjs on Twitter or file an issue at:

    https://github.com/notion-cli/notion/issues

Error details written to: notion-error-2019-04-16_23_21_20.063.log

It would be great to reduce all of the locations where "error: an internal error occurred:" as they aren't very user friendly / helpful.

@charlespierce
Copy link
Contributor Author

@thoov Agreed, that's tracked in #294 as the high-level issue, and I actually have a PR open right now #344 that finishes removing all the "internal errors" and replaces them with more contextual errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants