Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2737 to release/v1.7 for Fix update deps workflow: buf is not found #2739

Conversation

vdaas-ci
Copy link
Collaborator

@vdaas-ci vdaas-ci commented Nov 13, 2024

Description

SSIA

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.2
  • Rust Version: v1.81.0
  • Docker Version: v27.3.1
  • Kubernetes Version: v1.31.1
  • Helm Version: v3.16.2
  • NGT Version: v2.2.4
  • Faiss Version: v1.9.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Chores
    • Updated the dependency management workflow to include an additional step for handling dependency updates.

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: vankichi <kyukawa315@gmail.com>
Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2615d58
Status: ✅  Deploy successful!
Preview URL: https://d0fc3cf9.vald.pages.dev
Branch Preview URL: https://backport-release-v1-7-ci-wor.vald.pages.dev

View logs

Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

📝 Walkthrough

Walkthrough

The pull request modifies the workflow file .github/workflows/update-deps.yaml by adding the command make deps to the update-version job. This new command is executed after the existing make update command, allowing for the updating of dependencies as part of the workflow. The overall structure and logic of the workflow, including the steps for checking differences and creating pull requests, remain unchanged.

Changes

File Change Summary
.github/workflows/update-deps.yaml Added make deps command to update-version job after make update.

Possibly related PRs

Suggested labels

priority/low, size/S, type/ci, actions/backport/release/v1.7

Suggested reviewers

  • vankichi
  • datelier

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator Author

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
.github/workflows/update-deps.yaml (2)

Line range hint 44-54: Consider command execution order and dependencies

The placement of make deps between make update and make helm/schema/all seems logical in terms of dependency management flow. However, we should ensure that:

  1. make deps doesn't override any changes made by make update
  2. Subsequent commands like helm/schema/all have their dependencies satisfied

Consider documenting the dependencies between these make targets in the Makefile to make the workflow more maintainable.


Line range hint 71-77: Fix version comparison in label selection logic

There's a syntax error in the version comparison:

if ${LATEST} eq "1.7"; then

This is incorrect shell syntax and will fail.

Apply this fix:

-          if ${LATEST} eq "1.7"; then
+          if [ "${LATEST}" = "1.7" ]; then
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 63f0478 and 2615d58.

📒 Files selected for processing (1)
  • .github/workflows/update-deps.yaml (1 hunks)
🔇 Additional comments (1)
.github/workflows/update-deps.yaml (1)

45-45: Verify if make deps resolves the buf tool issue

While adding make deps is a logical step for dependency management, we should verify if this command actually installs or configures the buf tool as intended.

Let's check the Makefile for the deps target implementation:

✅ Verification successful

make deps correctly handles buf tool installation

The make deps command properly installs and configures the buf tool as intended.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the deps target in Makefile handles buf tool installation

# Search for buf-related commands in the deps target
rg -A 5 'deps:' Makefile

# Check if buf is mentioned in any make targets
rg 'buf' Makefile

Length of output: 256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants