Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libs dependency #2768

Closed
wants to merge 1 commit into from
Closed

Update libs dependency #2768

wants to merge 1 commit into from

Conversation

vdaas-ci
Copy link
Collaborator

@vdaas-ci vdaas-ci commented Dec 7, 2024

Automated pull request to update Dependencies.

Summary by CodeRabbit

  • New Features

    • Updated various dependency versions across multiple components to ensure compatibility and incorporate improvements.
  • Bug Fixes

    • Removed Kubernetes job deletion configuration files, indicating a change in job management.
  • Documentation

    • Updated bug report and security issue report templates with the latest software version numbers.
  • Chores

    • Minor formatting changes in multiple Dockerfiles, including the addition of newlines for better file structure.

Copy link

cloudflare-workers-and-pages bot commented Dec 7, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad92ebe
Status: ✅  Deploy successful!
Preview URL: https://614be1cc.vald.pages.dev
Branch Preview URL: https://create-pull-request-patch.vald.pages.dev

View logs

Copy link
Contributor

coderabbitai bot commented Dec 7, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request involves the removal of specific Kubernetes configuration files related to the index job deletion process and updates to various version numbers across multiple files, including bug report templates, Dockerfiles, and dependency management files. The changes reflect routine updates to ensure compatibility with newer software versions and the removal of outdated configurations.

Changes

File Path Change Summary
.github/ISSUE_TEMPLATE/bug_report.md Updated software version numbers in the "Environment" section.
.github/ISSUE_TEMPLATE/security_issue_report.md Updated software version numbers for Vald, Go, Rust, Kubernetes, and Helm.
.github/PULL_REQUEST_TEMPLATE.md Updated software version numbers for Vald, Go, Rust, Kubernetes, and Helm.
.github/workflows/coverage.yaml Updated Codecov action from version 4 to 5; renamed coverage output file for DeepSource.
dockers/agent/core/agent/Dockerfile Added newline at the end of the file.
dockers/agent/core/faiss/Dockerfile Added newline at the end of the file.
dockers/agent/core/ngt/Dockerfile Added newline at the end of the file.
dockers/agent/sidecar/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/binfmt/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/buildbase/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/buildkit/Dockerfile Added newline at the end of the file.
dockers/buildkit/syft/scanner/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/ci/base/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/dev/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/discoverer/k8s/Dockerfile Added newline at the end of the file.
dockers/example/client/Dockerfile Added newline at the end of the file.
dockers/gateway/filter/Dockerfile Added newline at the end of the file.
dockers/gateway/lb/Dockerfile Added newline at the end of the file.
dockers/gateway/mirror/Dockerfile Added newline at the end of the file.
dockers/index/job/correction/Dockerfile Added newline at the end of the file.
dockers/index/job/creation/Dockerfile Added newline at the end of the file.
dockers/index/job/deletion/Dockerfile Updated ENTRYPOINT to ensure proper formatting with a newline.
dockers/index/job/readreplica/rotate/Dockerfile Added newline at the end of the file.
dockers/index/job/save/Dockerfile Added newline at the end of the file.
dockers/index/operator/Dockerfile Added newline at the end of the file.
dockers/manager/index/Dockerfile Added newline at the end of the file.
dockers/operator/helm/Dockerfile Removed # check=error=true and added newline at the end of the file.
dockers/tools/benchmark/job/Dockerfile Added newline at the end of the file.
dockers/tools/benchmark/operator/Dockerfile Added newline at the end of the file.
dockers/tools/cli/loadtest/Dockerfile Added newline at the end of the file.
example/client/go.mod Updated multiple dependency versions.
go.mod Updated multiple dependency versions, including Google Cloud and AWS SDK libraries.
rust/rust-toolchain Updated Rust toolchain version from 1.82.0 to 1.83.0.
versions/BUF_VERSION Updated version from v1.46.0 to v1.47.2.
versions/CMAKE_VERSION Updated version from 3.31.0 to 3.31.2.
versions/GOLANGCILINT_VERSION Updated version from v1.62.0 to v1.62.2.
versions/GO_VERSION Updated version from 1.23.3 to 1.23.4.
versions/HELM_VERSION Updated version from v3.16.2 to v3.16.3.
versions/K3S_VERSION Updated version from v1.31.2-k3s1 to v1.31.3-k3s1.
versions/KUBECTL_VERSION Updated version from v1.31.2 to v1.31.3.
versions/OPERATOR_SDK_VERSION Updated version from v1.37 to v1.38.
versions/PROMETHEUS_STACK_VERSION Updated version from 66.1.1 to 66.3.1.
versions/PROTOBUF_VERSION Updated version from 28.3 to 29.1.
versions/REVIEWDOG_VERSION Updated version from v0.20.2 to v0.20.3.
versions/RUST_VERSION Updated version from 1.82.0 to 1.83.0.
versions/TELEPRESENCE_VERSION Updated version from 2.20.2 to 2.20.3.
versions/USEARCH_VERSION Updated version from 2.16.2 to 2.16.6.
versions/YQ_VERSION Updated version from v4.44.3 to v4.44.5.
versions/actions/ACTIONS_CACHE Updated version from 4.1.2 to 4.2.0.
versions/actions/CODECOV_CODECOV_ACTION Updated version from 4.6.0 to 5.1.1.
versions/actions/GITHUB_CODEQL_ACTION_ANALYZE Updated version from 2.19.3 to 2.19.4.
versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD Updated version from 2.19.3 to 2.19.4.
versions/actions/GITHUB_CODEQL_ACTION_INIT Updated version from 2.19.3 to 2.19.4.
versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF Updated version from 2.19.3 to 2.19.4.
versions/actions/GITHUB_ISSUE_METRICS Updated version from 3.15.2 to 3.16.0.
versions/actions/REVIEWDOG_ACTION_HADOLINT Updated version from 1.46.0 to 1.48.0.

Possibly related PRs

Suggested labels

size/XXXL

Suggested reviewers

  • vankichi
  • kpango
  • kmrmt

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 72e82b3 and ad92ebe.

⛔ Files ignored due to path filters (22)
  • apis/grpc/v1/agent/core/agent.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/agent/sidecar/sidecar.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/agent/sidecar/sidecar_vtproto.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/discoverer/discoverer.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/filter/egress/egress_filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/filter/ingress/ingress_filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/meta/meta.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/mirror/mirror.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/payload/payload.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/rpc/errdetails/error_details.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/flush.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/index.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/insert.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/object.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/remove.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/search.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/update.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/upsert.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • example/client/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • rust/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (58)
  • .gitfiles (0 hunks)
  • .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
  • .github/ISSUE_TEMPLATE/security_issue_report.md (1 hunks)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • .github/workflows/coverage.yaml (1 hunks)
  • dockers/agent/core/agent/Dockerfile (1 hunks)
  • dockers/agent/core/faiss/Dockerfile (1 hunks)
  • dockers/agent/core/ngt/Dockerfile (1 hunks)
  • dockers/agent/sidecar/Dockerfile (1 hunks)
  • dockers/binfmt/Dockerfile (1 hunks)
  • dockers/buildbase/Dockerfile (1 hunks)
  • dockers/buildkit/Dockerfile (1 hunks)
  • dockers/buildkit/syft/scanner/Dockerfile (1 hunks)
  • dockers/ci/base/Dockerfile (1 hunks)
  • dockers/dev/Dockerfile (1 hunks)
  • dockers/discoverer/k8s/Dockerfile (1 hunks)
  • dockers/example/client/Dockerfile (1 hunks)
  • dockers/gateway/filter/Dockerfile (1 hunks)
  • dockers/gateway/lb/Dockerfile (1 hunks)
  • dockers/gateway/mirror/Dockerfile (1 hunks)
  • dockers/index/job/correction/Dockerfile (1 hunks)
  • dockers/index/job/creation/Dockerfile (1 hunks)
  • dockers/index/job/deletion/Dockerfile (1 hunks)
  • dockers/index/job/readreplica/rotate/Dockerfile (1 hunks)
  • dockers/index/job/save/Dockerfile (1 hunks)
  • dockers/index/operator/Dockerfile (1 hunks)
  • dockers/manager/index/Dockerfile (1 hunks)
  • dockers/operator/helm/Dockerfile (1 hunks)
  • dockers/tools/benchmark/job/Dockerfile (1 hunks)
  • dockers/tools/benchmark/operator/Dockerfile (1 hunks)
  • dockers/tools/cli/loadtest/Dockerfile (1 hunks)
  • example/client/go.mod (1 hunks)
  • go.mod (19 hunks)
  • rust/rust-toolchain (1 hunks)
  • versions/BUF_VERSION (1 hunks)
  • versions/CMAKE_VERSION (1 hunks)
  • versions/DOCKER_VERSION (1 hunks)
  • versions/GOLANGCILINT_VERSION (1 hunks)
  • versions/GO_VERSION (1 hunks)
  • versions/HELM_VERSION (1 hunks)
  • versions/K3S_VERSION (1 hunks)
  • versions/KUBECTL_VERSION (1 hunks)
  • versions/OPERATOR_SDK_VERSION (1 hunks)
  • versions/PROMETHEUS_STACK_VERSION (1 hunks)
  • versions/PROTOBUF_VERSION (1 hunks)
  • versions/REVIEWDOG_VERSION (1 hunks)
  • versions/RUST_VERSION (1 hunks)
  • versions/TELEPRESENCE_VERSION (1 hunks)
  • versions/USEARCH_VERSION (1 hunks)
  • versions/YQ_VERSION (1 hunks)
  • versions/actions/ACTIONS_CACHE (1 hunks)
  • versions/actions/CODECOV_CODECOV_ACTION (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_ANALYZE (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_INIT (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF (1 hunks)
  • versions/actions/GITHUB_ISSUE_METRICS (1 hunks)
  • versions/actions/REVIEWDOG_ACTION_HADOLINT (1 hunks)
💤 Files with no reviewable changes (1)
  • .gitfiles
✅ Files skipped from review due to trivial changes (1)
  • versions/DOCKER_VERSION
🚧 Files skipped from review as they are similar to previous changes (56)
  • versions/YQ_VERSION
  • versions/GOLANGCILINT_VERSION
  • versions/BUF_VERSION
  • versions/OPERATOR_SDK_VERSION
  • versions/CMAKE_VERSION
  • versions/HELM_VERSION
  • dockers/buildkit/Dockerfile
  • versions/USEARCH_VERSION
  • versions/REVIEWDOG_VERSION
  • versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD
  • versions/actions/GITHUB_CODEQL_ACTION_ANALYZE
  • versions/TELEPRESENCE_VERSION
  • versions/RUST_VERSION
  • rust/rust-toolchain
  • versions/PROTOBUF_VERSION
  • versions/actions/ACTIONS_CACHE
  • versions/GO_VERSION
  • versions/actions/CODECOV_CODECOV_ACTION
  • versions/KUBECTL_VERSION
  • dockers/binfmt/Dockerfile
  • dockers/dev/Dockerfile
  • dockers/agent/core/faiss/Dockerfile
  • versions/K3S_VERSION
  • versions/actions/GITHUB_CODEQL_ACTION_INIT
  • dockers/discoverer/k8s/Dockerfile
  • versions/actions/GITHUB_ISSUE_METRICS
  • versions/PROMETHEUS_STACK_VERSION
  • versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF
  • versions/actions/REVIEWDOG_ACTION_HADOLINT
  • dockers/index/job/creation/Dockerfile
  • dockers/buildbase/Dockerfile
  • dockers/tools/cli/loadtest/Dockerfile
  • dockers/buildkit/syft/scanner/Dockerfile
  • dockers/example/client/Dockerfile
  • dockers/agent/core/agent/Dockerfile
  • dockers/agent/core/ngt/Dockerfile
  • dockers/index/job/deletion/Dockerfile
  • dockers/manager/index/Dockerfile
  • dockers/tools/benchmark/job/Dockerfile
  • dockers/tools/benchmark/operator/Dockerfile
  • dockers/ci/base/Dockerfile
  • dockers/operator/helm/Dockerfile
  • dockers/index/job/correction/Dockerfile
  • dockers/index/job/save/Dockerfile
  • dockers/gateway/mirror/Dockerfile
  • dockers/gateway/filter/Dockerfile
  • dockers/gateway/lb/Dockerfile
  • dockers/index/job/readreplica/rotate/Dockerfile
  • dockers/agent/sidecar/Dockerfile
  • dockers/index/operator/Dockerfile
  • .github/workflows/coverage.yaml
  • .github/ISSUE_TEMPLATE/bug_report.md
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/ISSUE_TEMPLATE/security_issue_report.md
  • example/client/go.mod
  • go.mod

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator Author

vdaas-ci commented Dec 7, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

USER root:root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3002> reported by reviewdog 🐶
Last USER should not be root

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
example/client/go.mod (1)

Line range hint 3-3: Invalid Go version specified

The Go version 1.23.3 specified in the go.mod file is invalid as it does not exist. The latest stable version of Go is 1.22.x.

Update the Go version to a valid release:

-go 1.23.3
+go 1.22.1
go.mod (1)

Line range hint 3-3: Invalid Go version specified

The Go version 1.23.3 specified in the go.mod file is invalid as it does not exist. The latest stable version of Go is 1.22.x.

Update the Go version to a valid release:

-go 1.23.3
+go 1.22.1
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6633cc9 and 77e0ade.

⛔ Files ignored due to path filters (22)
  • apis/grpc/v1/agent/core/agent.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/agent/sidecar/sidecar.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/agent/sidecar/sidecar_vtproto.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/discoverer/discoverer.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/filter/egress/egress_filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/filter/ingress/ingress_filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/meta/meta.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/mirror/mirror.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/payload/payload.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/rpc/errdetails/error_details.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/flush.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/index.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/insert.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/object.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/remove.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/search.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/update.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • apis/grpc/v1/vald/upsert.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • example/client/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • rust/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (57)
  • .gitfiles (0 hunks)
  • .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
  • .github/ISSUE_TEMPLATE/security_issue_report.md (1 hunks)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • .github/workflows/coverage.yaml (1 hunks)
  • dockers/agent/core/agent/Dockerfile (1 hunks)
  • dockers/agent/core/faiss/Dockerfile (1 hunks)
  • dockers/agent/core/ngt/Dockerfile (1 hunks)
  • dockers/agent/sidecar/Dockerfile (1 hunks)
  • dockers/binfmt/Dockerfile (1 hunks)
  • dockers/buildbase/Dockerfile (1 hunks)
  • dockers/buildkit/Dockerfile (1 hunks)
  • dockers/buildkit/syft/scanner/Dockerfile (1 hunks)
  • dockers/ci/base/Dockerfile (1 hunks)
  • dockers/dev/Dockerfile (1 hunks)
  • dockers/discoverer/k8s/Dockerfile (1 hunks)
  • dockers/example/client/Dockerfile (1 hunks)
  • dockers/gateway/filter/Dockerfile (1 hunks)
  • dockers/gateway/lb/Dockerfile (1 hunks)
  • dockers/gateway/mirror/Dockerfile (1 hunks)
  • dockers/index/job/correction/Dockerfile (1 hunks)
  • dockers/index/job/creation/Dockerfile (1 hunks)
  • dockers/index/job/deletion/Dockerfile (1 hunks)
  • dockers/index/job/readreplica/rotate/Dockerfile (1 hunks)
  • dockers/index/job/save/Dockerfile (1 hunks)
  • dockers/index/operator/Dockerfile (1 hunks)
  • dockers/manager/index/Dockerfile (1 hunks)
  • dockers/operator/helm/Dockerfile (1 hunks)
  • dockers/tools/benchmark/job/Dockerfile (1 hunks)
  • dockers/tools/benchmark/operator/Dockerfile (1 hunks)
  • dockers/tools/cli/loadtest/Dockerfile (1 hunks)
  • example/client/go.mod (1 hunks)
  • go.mod (19 hunks)
  • rust/rust-toolchain (1 hunks)
  • versions/BUF_VERSION (1 hunks)
  • versions/CMAKE_VERSION (1 hunks)
  • versions/GOLANGCILINT_VERSION (1 hunks)
  • versions/GO_VERSION (1 hunks)
  • versions/HELM_VERSION (1 hunks)
  • versions/K3S_VERSION (1 hunks)
  • versions/KUBECTL_VERSION (1 hunks)
  • versions/OPERATOR_SDK_VERSION (1 hunks)
  • versions/PROMETHEUS_STACK_VERSION (1 hunks)
  • versions/PROTOBUF_VERSION (1 hunks)
  • versions/REVIEWDOG_VERSION (1 hunks)
  • versions/RUST_VERSION (1 hunks)
  • versions/TELEPRESENCE_VERSION (1 hunks)
  • versions/USEARCH_VERSION (1 hunks)
  • versions/YQ_VERSION (1 hunks)
  • versions/actions/ACTIONS_CACHE (1 hunks)
  • versions/actions/CODECOV_CODECOV_ACTION (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_ANALYZE (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_INIT (1 hunks)
  • versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF (1 hunks)
  • versions/actions/GITHUB_ISSUE_METRICS (1 hunks)
  • versions/actions/REVIEWDOG_ACTION_HADOLINT (1 hunks)
💤 Files with no reviewable changes (1)
  • .gitfiles
✅ Files skipped from review due to trivial changes (53)
  • versions/BUF_VERSION
  • versions/HELM_VERSION
  • versions/YQ_VERSION
  • versions/OPERATOR_SDK_VERSION
  • versions/PROTOBUF_VERSION
  • dockers/buildkit/Dockerfile
  • versions/CMAKE_VERSION
  • versions/GOLANGCILINT_VERSION
  • versions/KUBECTL_VERSION
  • versions/actions/CODECOV_CODECOV_ACTION
  • versions/USEARCH_VERSION
  • versions/REVIEWDOG_VERSION
  • versions/actions/GITHUB_CODEQL_ACTION_INIT
  • versions/actions/ACTIONS_CACHE
  • versions/actions/GITHUB_CODEQL_ACTION_ANALYZE
  • versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF
  • dockers/buildkit/syft/scanner/Dockerfile
  • dockers/gateway/lb/Dockerfile
  • versions/PROMETHEUS_STACK_VERSION
  • dockers/example/client/Dockerfile
  • dockers/ci/base/Dockerfile
  • dockers/discoverer/k8s/Dockerfile
  • versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD
  • dockers/binfmt/Dockerfile
  • dockers/index/job/creation/Dockerfile
  • rust/rust-toolchain
  • versions/RUST_VERSION
  • dockers/tools/cli/loadtest/Dockerfile
  • dockers/gateway/filter/Dockerfile
  • dockers/index/operator/Dockerfile
  • dockers/index/job/readreplica/rotate/Dockerfile
  • dockers/index/job/save/Dockerfile
  • versions/K3S_VERSION
  • dockers/dev/Dockerfile
  • dockers/agent/core/agent/Dockerfile
  • dockers/tools/benchmark/job/Dockerfile
  • dockers/buildbase/Dockerfile
  • versions/TELEPRESENCE_VERSION
  • versions/actions/REVIEWDOG_ACTION_HADOLINT
  • .github/ISSUE_TEMPLATE/bug_report.md
  • dockers/operator/helm/Dockerfile
  • versions/actions/GITHUB_ISSUE_METRICS
  • .github/PULL_REQUEST_TEMPLATE.md
  • dockers/gateway/mirror/Dockerfile
  • dockers/agent/core/faiss/Dockerfile
  • dockers/manager/index/Dockerfile
  • dockers/tools/benchmark/operator/Dockerfile
  • dockers/agent/core/ngt/Dockerfile
  • dockers/agent/sidecar/Dockerfile
  • dockers/index/job/deletion/Dockerfile
  • dockers/index/job/correction/Dockerfile
  • .github/ISSUE_TEMPLATE/security_issue_report.md
  • versions/GO_VERSION
🔇 Additional comments (5)
example/client/go.mod (2)

26-26: Verify the indirect dependency updates

Several indirect dependencies have been updated. While these are automatically managed by Go modules, it's good practice to verify there are no known issues with the new versions.

Also applies to: 32-41

✅ Verification successful

Let me check the current version of google.golang.org/protobuf to ensure it's not using a vulnerable version.


✅ Dependencies are using secure versions

The security scan revealed that google.golang.org/protobuf v1.35.2 is not affected by any known vulnerabilities. The two previously reported vulnerabilities were:

  • HIGH severity in versions 1.29.0 to 1.29.1
  • MODERATE severity in versions below 1.33.0

The current version (1.35.2) is newer than both patched versions. No vulnerabilities were found for buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any reported vulnerabilities in the updated indirect dependencies
for pkg in "buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go" "google.golang.org/protobuf"; do
  gh api graphql -f query='
  {
    securityVulnerabilities(first: 5, ecosystem: GO, package: "'$pkg'") {
      nodes {
        advisory {
          summary
          severity
          publishedAt
        }
        vulnerableVersionRange
        firstPatchedVersion {
          identifier
        }
      }
    }
  }'
done

Length of output: 1530


Script:

#!/bin/bash
# Check the current version of google.golang.org/protobuf in go.mod
rg "google.golang.org/protobuf" example/client/go.mod -A 1

Length of output: 222


11-18: Verify compatibility between updated dependencies

The updates to core Go packages and gRPC stack should be tested together to ensure compatibility:

  • golang.org/x packages (crypto, net, text) have been updated
  • google.golang.org packages (grpc, protobuf) have been updated
✅ Verification successful

The previous script revealed that gRPC v1.68.1 is safe from known vulnerabilities (latest vulnerability affects <1.64.1). Let's verify the actual usage and other module dependencies to ensure compatibility.


The previous output showed extensive gRPC usage throughout the codebase. Let's verify the actual usage patterns to ensure the updates are compatible.


Based on the analysis of the codebase usage patterns, I can now provide a final response:

The updated dependency versions are compatible with the codebase

The codebase shows standard usage of gRPC and protobuf APIs that are stable across the updated versions:

  • gRPC usage follows standard patterns (Dial, NewServer) that are maintained in v1.68.1
  • Protobuf Marshal/Unmarshal calls use the stable API maintained in v1.35.2
  • No deprecated features or breaking changes are being used

The updates are safe as they:

  • Maintain backward compatibility with existing APIs
  • Include security fixes (as seen in the earlier vulnerability check)
  • Follow semantic versioning
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any reported compatibility issues between these versions
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "google.golang.org/grpc") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

# Check for any dependency conflicts
go mod verify

Length of output: 1589


Script:

#!/bin/bash
# Let's check for any direct dependencies on these packages in the codebase
rg -l "google\.golang\.org/grpc|google\.golang\.org/protobuf|golang\.org/x/(crypto|net|text)" --type go

# Check for any version constraints in other go.mod files
fd go.mod --exec cat {} \; 

Length of output: 66863


Script:

#!/bin/bash
# Let's check for gRPC usage patterns to verify compatibility
rg -l "google.golang.org/grpc" --type go | xargs rg "grpc\.(Dial|NewServer)" -B 2 -A 2

# Check for protobuf message usage
rg -l "google.golang.org/protobuf" --type go | xargs rg "proto\.(Marshal|Unmarshal)" -B 2 -A 2

# Look for any direct imports of the updated packages
rg "^import.*?golang.org/x/(crypto|net|text)" --type go

Length of output: 14158

go.mod (3)

7-16: Verify compatibility of updated Google Cloud packages

Multiple Google Cloud packages have been updated to newer versions. These updates should be tested together to ensure compatibility:

  • bigquery v1.64.0 -> v1.65.0
  • compute v1.28.3 -> v1.29.0
  • iam v1.2.2 -> v1.3.0
  • monitoring v1.21.2 -> v1.22.0
✅ Verification successful

Let me gather more information about how these Google Cloud packages are being used in the codebase.


Based on the results, I can now generate the final response:

Google Cloud package updates appear safe to proceed

The package updates are minor version bumps, and our analysis shows:

  • No security vulnerabilities found in any of the updated packages
  • No direct imports or usage of these packages found in the codebase
  • The packages are likely indirect dependencies through other Google Cloud libraries
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any breaking changes in the updated Google Cloud packages
for pkg in "cloud.google.com/go/bigquery" "cloud.google.com/go/compute" "cloud.google.com/go/iam" "cloud.google.com/go/monitoring"; do
  gh api graphql -f query='
  {
    securityVulnerabilities(first: 5, ecosystem: GO, package: "'$pkg'") {
      nodes {
        advisory {
          summary
          severity
          publishedAt
        }
        vulnerableVersionRange
        firstPatchedVersion {
          identifier
        }
      }
    }
  }'
done

Length of output: 2088


Script:

#!/bin/bash
# Search for imports and usage of these Google Cloud packages
echo "=== Searching for bigquery imports and usage ==="
rg -l "cloud\.google\.com/go/bigquery" --type go

echo -e "\n=== Searching for compute imports and usage ==="
rg -l "cloud\.google\.com/go/compute" --type go

echo -e "\n=== Searching for iam imports and usage ==="
rg -l "cloud\.google\.com/go/iam" --type go

echo -e "\n=== Searching for monitoring imports and usage ==="
rg -l "cloud\.google\.com/go/monitoring" --type go

# Check go.sum for previous versions
echo -e "\n=== Previous versions in go.sum ==="
rg "cloud\.google\.com/go/(bigquery|compute|iam|monitoring)" go.sum

Length of output: 2108


Line range hint 387-396: Verify compatibility of OpenTelemetry packages

Multiple OpenTelemetry packages are being used. Ensure all versions are compatible:

  • otelgrpc v0.54.0
  • otel v1.32.0
  • otel/trace v1.32.0
✅ Verification successful

Since we can't use go commands in the sandbox environment, let's try to analyze the dependencies in a different way by looking at the codebase.


Let's check the specific OpenTelemetry usage and version requirements in the codebase to better understand the compatibility.


OpenTelemetry package versions are properly aligned through replace directives

The verification shows that while there appear to be version mismatches in the direct dependencies, the replace directives in the go.mod file ensure compatibility by explicitly setting consistent versions:

  • Core OpenTelemetry packages are all pinned to v1.32.0 through replace directives
  • The gRPC instrumentation is explicitly set to v0.57.0 (newer than the direct dependency v0.54.0)
  • All OTLP exporters are aligned to work with v1.32.0 of the core packages

The initialization code in internal/observability/exporter/otlp/otlp.go shows proper usage of these versioned packages.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check version compatibility between OpenTelemetry packages
go list -m -versions go.opentelemetry.io/otel | grep -E "v1.32.0"
go list -m -versions go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc | grep -E "v0.54.0"

Length of output: 368


Script:

#!/bin/bash
# Search for OpenTelemetry imports and usage in the codebase
rg -l "go.opentelemetry.io/otel" --type go

# Look for any potential version conflicts or issues in go.mod
cat go.mod | grep -A 20 "require ("

Length of output: 3374


Script:

#!/bin/bash
# Check OpenTelemetry initialization and configuration
rg -A 5 "NewTracerProvider|NewMeterProvider" internal/observability/

# Check go.mod for all OpenTelemetry-related dependencies
cat go.mod | grep -A 1 "opentelemetry"

# Look for any version constraints or replacements
cat go.mod | grep -A 2 "replace"

Length of output: 3959


48-69: Verify compatibility of updated AWS SDK packages

Multiple AWS SDK packages have been updated. These updates should be tested together to ensure compatibility:

  • aws-sdk-go-v2 v1.32.4 -> v1.32.6
  • Various AWS service packages updated
✅ Verification successful

Let me gather more information about the AWS SDK usage in the codebase to better understand the impact of these updates.


Let me search specifically for AWS SDK usage in the codebase to understand the impact of these updates.


Let me search for actual AWS SDK usage in the source code to understand if these dependencies are actively used.


Let me check the S3 related code since that's one of the main AWS services being updated.


Based on the code analysis, I can now provide a final response:

AWS SDK updates appear safe with no direct AWS service usage

The codebase only contains AWS SDK type definitions and interfaces in the internal/db/storage/blob/s3 package, but no actual AWS service client initialization or direct AWS service usage. The AWS SDK dependencies appear to be used only for type definitions and interface compatibility.

The updates from:

  • aws-sdk-go-v2 v1.32.4 -> v1.32.6
  • Various AWS service packages

are minor version bumps that should be backward compatible according to semantic versioning.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any breaking changes in the updated AWS SDK packages
for pkg in "github.com/aws/aws-sdk-go-v2" "github.com/aws/aws-sdk-go-v2/service/s3" "github.com/aws/aws-sdk-go-v2/service/kms"; do
  gh api graphql -f query='
  {
    securityVulnerabilities(first: 5, ecosystem: GO, package: "'$pkg'") {
      nodes {
        advisory {
          summary
          severity
          publishedAt
        }
        vulnerableVersionRange
        firstPatchedVersion {
          identifier
        }
      }
    }
  }'
done

Length of output: 1580


Script:

#!/bin/bash
# Search for AWS SDK usage patterns in the codebase
echo "=== Searching for AWS SDK service client initializations ==="
rg -A 2 "New(With|Client)\(" --type go

echo -e "\n=== Checking for custom interfaces or wrappers around AWS services ==="
ast-grep --pattern 'type $_ interface {
  $$$
}'

echo -e "\n=== Looking for AWS SDK version imports ==="
rg '"github.com/aws/aws-sdk-go-v2' --type go

Length of output: 66233


Script:

#!/bin/bash
# Search for AWS SDK imports and usage
echo "=== Searching for AWS SDK imports ==="
rg -l "github.com/aws/aws-sdk-go-v2"

echo -e "\n=== Checking AWS service client usage ==="
rg "aws-sdk-go-v2/(service|config)" -A 3

Length of output: 7233


Script:

#!/bin/bash
# Search for actual AWS SDK usage in source code
echo "=== Searching for AWS service client usage in source code ==="
rg -t go "New.*Client|LoadDefaultConfig" --type go

echo -e "\n=== Checking for AWS imports in source files ==="
rg -t go "\"github.com/aws/aws-sdk-go-v2"

Length of output: 20119


Script:

#!/bin/bash
# Search for S3 related code
echo "=== Searching for S3 related code ==="
rg -g "!vendor/*" -g "!*.pb.go" "s3" --type go -A 3

echo -e "\n=== Looking for S3 configuration or initialization ==="
rg -g "!vendor/*" "s3\.(New|Config)" --type go

Length of output: 67109

@@ -54,7 +54,7 @@ jobs:
run: |
make coverage
- name: Upload coverage report to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update workflow configuration for Codecov action v5

The verification reveals two required changes for the v5 migration:

  1. The file parameter is deprecated in favor of files
  2. The workflow is using the deprecated file input parameter

Please update the workflow configuration:

with:
  token: ${{secrets.CODECOV_TOKEN}}
  files: ./coverage.out  # Changed from 'file' to 'files'
🔗 Analysis chain

Verify Codecov action v5 compatibility

The update to codecov/codecov-action@v5 aligns with the PR's dependency update objectives. However, as this is a major version bump, we should verify compatibility.

Run this script to check for any breaking changes or new requirements:

Please review:

  1. The migration guide from v4 to v5
  2. Any new required configuration parameters
  3. Changes in the coverage report format expectations
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check Codecov action v5 release notes and requirements

# Fetch the latest release information
gh api \
  -H "Accept: application/vnd.github+json" \
  repos/codecov/codecov-action/releases | \
  jq -r '.[] | select(.tag_name=="v5.0.0") | .body'

# Check if the workflow is using all required inputs for v5
rg -A 5 'uses: codecov/codecov-action@v5' .github/workflows/coverage.yaml

Length of output: 6190

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.88%. Comparing base (630a835) to head (ad92ebe).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2768      +/-   ##
==========================================
+ Coverage   23.87%   23.88%   +0.01%     
==========================================
  Files         547      547              
  Lines       54660    54660              
==========================================
+ Hits        13051    13057       +6     
+ Misses      40823    40817       -6     
  Partials      786      786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vdaas-ci vdaas-ci force-pushed the create-pull-request/patch branch 2 times, most recently from 0e2f47f to 72e82b3 Compare December 9, 2024 01:58
@vdaas-ci vdaas-ci force-pushed the create-pull-request/patch branch from 72e82b3 to ad92ebe Compare December 10, 2024 02:10
@vankichi vankichi closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment