Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt or Ctrl +- to toggle zoom up and down #479

Closed
baconpaul opened this issue Feb 3, 2019 · 3 comments · Fixed by #501
Closed

Alt or Ctrl +- to toggle zoom up and down #479

baconpaul opened this issue Feb 3, 2019 · 3 comments · Fixed by #501

Comments

@baconpaul
Copy link
Collaborator

Do this along with the #433 and default zoom and the max zoom change
@baconpaul baconpaul changed the title Alt or Ctrl +- to togf!e zoom up and down Alt or Ctrl +- to togf zoom up and down Feb 3, 2019
@baconpaul baconpaul changed the title Alt or Ctrl +- to togf zoom up and down Alt or Ctrl +- to toggle zoom up and down Feb 3, 2019
@baconpaul
Copy link
Collaborator Author

#456 #457 #473

@esaruoho
Copy link
Collaborator

esaruoho commented Feb 3, 2019

what about cmd+/- on macOS?

@baconpaul
Copy link
Collaborator Author

Yeah whatever the natural key is is the one I will pick!

@baconpaul baconpaul mentioned this issue Feb 4, 2019
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 4, 2019
@baconpaul
Keycodes restored
bbe833c 
The onKeyDown handler was reading the wrong part of the data
structure, so keypresses didn't navigate patches. Moreover, the
handler was over-registered. Finally, once those problems were
fixes, make + and - zoom and unzoom the UI.

Closes surge-synthesizer#496 Keyboard Hook doesn't work
Closes surge-synthesizer#479 +/- for zoom
Closes surge-synthesizer#427 Keyboard hook over-registered
@baconpaul baconpaul mentioned this issue Feb 4, 2019
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 4, 2019
@baconpaul
Keycodes restored
5aef139 
The onKeyDown handler was reading the wrong part of the data
structure, so keypresses didn't navigate patches. Moreover, the
handler was over-registered. Finally, once those problems were
fixes, make + and - zoom and unzoom the UI.

Closes surge-synthesizer#496 Keyboard Hook doesn't work
Closes surge-synthesizer#479 +/- for zoom
Closes surge-synthesizer#427 Keyboard hook over-registered

Due to an error in windows VSTGUI this doesn't fully work on
windows, with the keyboard zoom not being supported there.
See issue surge-synthesizer#500 for a description of why.
@baconpaul baconpaul mentioned this issue Feb 4, 2019
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
Keycodes restored
3710db4 
The onKeyDown handler was reading the wrong part of the data
structure, so keypresses didn't navigate patches. Moreover, the
handler was over-registered. Finally, once those problems were
fixes, make + and - zoom and unzoom the UI.

Closes surge-synthesizer#496 Keyboard Hook doesn't work
Closes surge-synthesizer#479 +/- for zoom
Closes surge-synthesizer#427 Keyboard hook over-registered

Due to an error in windows VSTGUI this doesn't fully work on
windows, with the keyboard zoom not being supported there.
See issue surge-synthesizer#500 for a description of why.


Former-commit-id: e0ff13f2588bbfec2ece60f9217e17522756d0fa [formerly 5aef139]
Former-commit-id: 9e8d3af55f3c457372964310ba83c19e29da1224
Former-commit-id: f8a51113f2f5e6d738efa060371ab5fbd4cf095a
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keycodes restored baconpaul/surge
Keycodes restored baconpaul/surge
2 participants
@esaruoho @baconpaul