Keyboard Hook doesn't work #496
Comments
baconpaul
changed the title
|
Right so the problem, as well as being registered n times rather than one (as pointed out in #427) is that we switch on code.character looking for VKEY_LEFT and stuff and should switch on code.virt. etc... fairly easy to clean up and test. May do it tonight with a PR which closes this #427 and #479. |
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Feb 4, 2019
The onKeyDown handler was reading the wrong part of the data structure, so keypresses didn't navigate patches. Moreover, the handler was over-registered. Finally, once those problems were fixes, make + and - zoom and unzoom the UI. Closes surge-synthesizer#496 Keyboard Hook doesn't work Closes surge-synthesizer#479 +/- for zoom Closes surge-synthesizer#427 Keyboard hook over-registered
Closed
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Feb 4, 2019
The onKeyDown handler was reading the wrong part of the data structure, so keypresses didn't navigate patches. Moreover, the handler was over-registered. Finally, once those problems were fixes, make + and - zoom and unzoom the UI. Closes surge-synthesizer#496 Keyboard Hook doesn't work Closes surge-synthesizer#479 +/- for zoom Closes surge-synthesizer#427 Keyboard hook over-registered Due to an error in windows VSTGUI this doesn't fully work on windows, with the keyboard zoom not being supported there. See issue surge-synthesizer#500 for a description of why.
Merged
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jul 10, 2019
The onKeyDown handler was reading the wrong part of the data structure, so keypresses didn't navigate patches. Moreover, the handler was over-registered. Finally, once those problems were fixes, make + and - zoom and unzoom the UI. Closes surge-synthesizer#496 Keyboard Hook doesn't work Closes surge-synthesizer#479 +/- for zoom Closes surge-synthesizer#427 Keyboard hook over-registered Due to an error in windows VSTGUI this doesn't fully work on windows, with the keyboard zoom not being supported there. See issue surge-synthesizer#500 for a description of why. Former-commit-id: e0ff13f2588bbfec2ece60f9217e17522756d0fa [formerly 5aef139] Former-commit-id: 9e8d3af55f3c457372964310ba83c19e29da1224 Former-commit-id: f8a51113f2f5e6d738efa060371ab5fbd4cf095a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In addition to #427 the keyboard hook generally doesn't do what you'd want. I think it is just coded incorrectly. Right now it is looking at KeyCode.character for things like LEFT and RIGHT, when those control keys send a character of 0.
Came across this doing #479 so will hold that one too, to do some general keyboard hook cleanups including fixing the leak referenced above, making existing functions work, and adding keyboard zoom.
Confirmed this is a problem win + mac both.
The text was updated successfully, but these errors were encountered: