Overzoom detection: try first lower zoom level instead not doing anything #457
Comments
|
Yeah for the @sense-amr issue #456 I need a best-fit-for-monitor heuristic also so I can do both at the same time. Thanks! Probably won't do these this weekend but we can get to em. Good ideas both. |
|
Oh and @sense-amr thanks for tagging me! But I get notifications for all issues already since I'm one of the maintainers. Appreciate it but I would have seen this even if you hadn't. No worries that you did of course! |
|
ahh yeah i just remember it was something we discussed.. but i didnt know it was possible on AU .. im not developing on the mac much or using it .. mostly PC testing here. . |
|
OK here's the new message. All part of my big zoom cleanup branch. Should be headed to a PR today sometime. Maybe tomorrow latest. |
If you ask for a zoom which outstrips screen parameters, rather than retain the current zoom look for the largest zoom that will fit those paramemters.
|
@baconpaul i would really hope that you could up it to 98% or something.. please? :) |
|
I could make you one which goes up to 98%. Then you would go to that. Then you would ask me to back it down. Because you would have lost the menu button because of the menu bar and window decoration. Remember: This is setting the size of the surge window INSIDE the decorated window sitting in a desktop with other components. On a mac you loose 20 pixels or so for the menu bar at the top. You lose another chunk for the window border. On windows it is worse. |
|
The easiest fix is to just lie to the user and not show them the 95% thing at all! I'll do that before I do the PR. |
|
There you go! |
Once folks started using zoom, a variety of small enhancement requests came in. This PR covers all of them, covering several tickets. The issues resolved are: Closes surge-synthesizer#483. Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM switch, since all hosts support zoom. To make it testable, ahead of implementing DisplayInfo on linux, set the defaulted screen size to 1400x1050, a mid-range 15" laptop. Closes surge-synthesizer#433 Correct the error message at zoom time to explain we add a window-decoration-protection factor but don't show the confusing dimensions that result. Closes surge-synthesizer#473 Order and add separator to the setting menu to be more rational. Keep "About" at the end. Closes surge-synthesizer#457 If you ask for a zoom which outstrips screen parameters, rather than retain the current zoom look for the largest zoom that will fit those paramemters. Don't display the confusing-to-users message about how much space we are reserving for window decoration.
Once folks started using zoom, a variety of small enhancement requests came in. This PR covers all of them, covering several tickets. The issues resolved are: Closes surge-synthesizer#483. Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM switch, since all hosts support zoom. To make it testable, ahead of implementing DisplayInfo on linux, set the defaulted screen size to 1400x1050, a mid-range 15" laptop. Closes surge-synthesizer#433 Correct the error message at zoom time to explain we add a window-decoration-protection factor but don't show the confusing dimensions that result. Closes surge-synthesizer#473 Order and add separator to the setting menu to be more rational. Keep "About" at the end. Closes surge-synthesizer#457 If you ask for a zoom which outstrips screen parameters, rather than retain the current zoom look for the largest zoom that will fit those paramemters. Don't display the confusing-to-users message about how much space we are reserving for window decoration. Former-commit-id: b9041bc092419fccd60c8cba96363f32aea90302 [formerly 9cbf0f3] Former-commit-id: f2c661d7267b64671d59fda5f1a52a5af31666e9 Former-commit-id: 7c24b0858337885a11eb3a28ff9acc0f45648ab8
Right now when overzooming detects that the chosen GUI size won't fit your screen, I feel it would be better to try the next lower zoom level, then recurse that if it still doesn't fit (say you selected 300% on 1080p monitor). This way we could end up with the best possible fit, instead of nothing happening and requiring the user to visit the menu again to choose another zoom level.
Thanks!
The text was updated successfully, but these errors were encountered: