Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable zoom on Linux #483

Closed
baconpaul opened this issue Feb 3, 2019 · 1 comment · Fixed by #497
Closed

Enable zoom on Linux #483

baconpaul opened this issue Feb 3, 2019 · 1 comment · Fixed by #497

Comments

@baconpaul
Copy link
Collaborator

As part of the big #433 family I might as well turn on Linux zoom and get rid of host supports zoom compiler time switches so add this to the family of “zoom cleanup” tickets all linked around 433
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 4, 2019
@baconpaul
A Variety of Zoom Enhancements
d4e404a 
Once folks started using zoom, a variety of small enhancement
requests came in. This PR covers all of them, covering several
tickets.

The issues resolved are:

Closes surge-synthesizer#483.
Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM
switch, since all hosts support zoom. To make it testable, ahead
of implementing DisplayInfo on linux, set the defaulted screen size
to 1400x1050, a mid-range 15" laptop.
@baconpaul
Copy link
Collaborator Author

I have a branch fixing a collection of small zoom issues (baconpaul/zoom-enhancements-433) and it fixes this one. PR maybe later this morning.

baconpaul added a commit to baconpaul/surge that referenced this issue Feb 4, 2019
@baconpaul
A Variety of Zoom Enhancements
9cbf0f3 
Once folks started using zoom, a variety of small enhancement
requests came in. This PR covers all of them, covering several
tickets.

The issues resolved are:

Closes surge-synthesizer#483.
Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM
switch, since all hosts support zoom. To make it testable, ahead
of implementing DisplayInfo on linux, set the defaulted screen size
to 1400x1050, a mid-range 15" laptop.

Closes surge-synthesizer#433
Correct the error message at zoom time to explain we add
a window-decoration-protection factor but don't show the
confusing dimensions that result.

Closes surge-synthesizer#473
Order and add separator to the setting menu to be more
rational. Keep "About" at the end.

Closes surge-synthesizer#457
If you ask for a zoom which outstrips screen parameters, rather than
retain the current zoom look for the largest zoom that will fit those
paramemters. Don't display the confusing-to-users message about how
much space we are reserving for window decoration.
@baconpaul baconpaul mentioned this issue Feb 4, 2019
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
A Variety of Zoom Enhancements
4425e4a 
Once folks started using zoom, a variety of small enhancement
requests came in. This PR covers all of them, covering several
tickets.

The issues resolved are:

Closes surge-synthesizer#483.
Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM
switch, since all hosts support zoom. To make it testable, ahead
of implementing DisplayInfo on linux, set the defaulted screen size
to 1400x1050, a mid-range 15" laptop.

Closes surge-synthesizer#433
Correct the error message at zoom time to explain we add
a window-decoration-protection factor but don't show the
confusing dimensions that result.

Closes surge-synthesizer#473
Order and add separator to the setting menu to be more
rational. Keep "About" at the end.

Closes surge-synthesizer#457
If you ask for a zoom which outstrips screen parameters, rather than
retain the current zoom look for the largest zoom that will fit those
paramemters. Don't display the confusing-to-users message about how
much space we are reserving for window decoration.


Former-commit-id: b9041bc092419fccd60c8cba96363f32aea90302 [formerly 9cbf0f3]
Former-commit-id: f2c661d7267b64671d59fda5f1a52a5af31666e9
Former-commit-id: 7c24b0858337885a11eb3a28ff9acc0f45648ab8
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A Variety of Zoom Enhancements baconpaul/surge
1 participant
@baconpaul