Beautify Zoom-error-dialog to be more accurate #433
Comments
|
surge capitalisation PR at #434 - the rest i'll leave up to @baconpaul |
|
Oh window decoration eats about 5-10% of pixels so I cropped it below that. Although we should change the error message to be less annoying in that case agreed! The error is pretty easy to find. Look for a prompterror in surgeguieditor.cpp setzoomfactor I think. Happy for you to rewrite it if you want! |
|
yeah i wrote it.. but the weird -1084 throws me off.. why would be a height be in minus |
|
Well, we can move some of the text here: 1440x877 cannot be resized higher than 135% - not even 145%. |
|
Overall feels like Zoom could be a bit more dangerous, and maybe a bit more precise: When resizing to 150%
When resizing from 135% to 145%..
|
|
these are two different things, however, @baconpaul - this was about tweaking the text to be accurate, the other issue was about not being able to get to "semi-large" screen sizes of surge without running into issues.. |
|
Yup but it's all the same .9 choice |
|
OK there's the new message (for now; soon it will pick a best-largest screen size and say that in the last line instead). |
|
I'm taking on of the "Size"s out of the title. So "Limiting Zoom by Screen Size" |
Correct the error message at zoom time to explain we add a window-decoration-protection factor but don't show the confusing dimensions that result.
Once folks started using zoom, a variety of small enhancement requests came in. This PR covers all of them, covering several tickets. The issues resolved are: Closes surge-synthesizer#483. Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM switch, since all hosts support zoom. To make it testable, ahead of implementing DisplayInfo on linux, set the defaulted screen size to 1400x1050, a mid-range 15" laptop. Closes surge-synthesizer#433 Correct the error message at zoom time to explain we add a window-decoration-protection factor but don't show the confusing dimensions that result. Closes surge-synthesizer#473 Order and add separator to the setting menu to be more rational. Keep "About" at the end. Closes surge-synthesizer#457 If you ask for a zoom which outstrips screen parameters, rather than retain the current zoom look for the largest zoom that will fit those paramemters. Don't display the confusing-to-users message about how much space we are reserving for window decoration.
Once folks started using zoom, a variety of small enhancement requests came in. This PR covers all of them, covering several tickets. The issues resolved are: Closes surge-synthesizer#483. Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM switch, since all hosts support zoom. To make it testable, ahead of implementing DisplayInfo on linux, set the defaulted screen size to 1400x1050, a mid-range 15" laptop. Closes surge-synthesizer#433 Correct the error message at zoom time to explain we add a window-decoration-protection factor but don't show the confusing dimensions that result. Closes surge-synthesizer#473 Order and add separator to the setting menu to be more rational. Keep "About" at the end. Closes surge-synthesizer#457 If you ask for a zoom which outstrips screen parameters, rather than retain the current zoom look for the largest zoom that will fit those paramemters. Don't display the confusing-to-users message about how much space we are reserving for window decoration. Former-commit-id: b9041bc092419fccd60c8cba96363f32aea90302 [formerly 9cbf0f3] Former-commit-id: f2c661d7267b64671d59fda5f1a52a5af31666e9 Former-commit-id: 7c24b0858337885a11eb3a28ff9acc0f45648ab8
"Your screen is 1920x1177 and your zoom of 200% would make your surge 1808x-1084".
Not sure what that is, or why I can't get 200% even though i can.
The text was updated successfully, but these errors were encountered: