Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder entries in Menu #473

Closed
mkruselj opened this issue Feb 2, 2019 · 0 comments · Fixed by #497
Closed

Reorder entries in Menu #473

mkruselj opened this issue Feb 2, 2019 · 0 comments · Fixed by #497

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Feb 2, 2019

To me, it makes a lot more sense to have "About" last in the menu, and "Zoom" probably first. So, I suggest just inverting the order of entries in the Menu. Perhaps add a separator. Like this:

Zoom       >
------------
Surge Manual
About Surge
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 4, 2019
Order and add separator to the setting menu to be more
rational. Keep "About" at the end.
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 4, 2019
Once folks started using zoom, a variety of small enhancement
requests came in. This PR covers all of them, covering several
tickets.

The issues resolved are:

Closes surge-synthesizer#483.
Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM
switch, since all hosts support zoom. To make it testable, ahead
of implementing DisplayInfo on linux, set the defaulted screen size
to 1400x1050, a mid-range 15" laptop.

Closes surge-synthesizer#433
Correct the error message at zoom time to explain we add
a window-decoration-protection factor but don't show the
confusing dimensions that result.

Closes surge-synthesizer#473
Order and add separator to the setting menu to be more
rational. Keep "About" at the end.

Closes surge-synthesizer#457
If you ask for a zoom which outstrips screen parameters, rather than
retain the current zoom look for the largest zoom that will fit those
paramemters. Don't display the confusing-to-users message about how
much space we are reserving for window decoration.
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
Once folks started using zoom, a variety of small enhancement
requests came in. This PR covers all of them, covering several
tickets.

The issues resolved are:

Closes surge-synthesizer#483.
Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM
switch, since all hosts support zoom. To make it testable, ahead
of implementing DisplayInfo on linux, set the defaulted screen size
to 1400x1050, a mid-range 15" laptop.

Closes surge-synthesizer#433
Correct the error message at zoom time to explain we add
a window-decoration-protection factor but don't show the
confusing dimensions that result.

Closes surge-synthesizer#473
Order and add separator to the setting menu to be more
rational. Keep "About" at the end.

Closes surge-synthesizer#457
If you ask for a zoom which outstrips screen parameters, rather than
retain the current zoom look for the largest zoom that will fit those
paramemters. Don't display the confusing-to-users message about how
much space we are reserving for window decoration.


Former-commit-id: b9041bc092419fccd60c8cba96363f32aea90302 [formerly 9cbf0f3]
Former-commit-id: f2c661d7267b64671d59fda5f1a52a5af31666e9
Former-commit-id: 7c24b0858337885a11eb3a28ff9acc0f45648ab8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant