Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): set use_kzg_da flag in build block input #2345

Open
wants to merge 1 commit into
base: arni/batcher/block_builder_factory/set_block_timestamp
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 27.16%. Comparing base (3bb7ed9) to head (ef924ab).

Files with missing lines Patch % Lines
crates/starknet_api/src/block.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                                     Coverage Diff                                     @@
##           arni/batcher/block_builder_factory/set_block_timestamp    #2345       +/-   ##
===========================================================================================
+ Coverage                                                   13.44%   27.16%   +13.72%     
===========================================================================================
  Files                                                         188      121       -67     
  Lines                                                       24164    13932    -10232     
  Branches                                                    24164    13932    -10232     
===========================================================================================
+ Hits                                                         3248     3785      +537     
+ Misses                                                      20590     9811    -10779     
- Partials                                                      326      336       +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_block_timestamp branch from a21cac0 to 3bb7ed9 Compare November 28, 2024 15:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from 0b1faae to ef924ab Compare November 28, 2024 15:34
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_block_timestamp branch from 3bb7ed9 to c65933e Compare December 1, 2024 12:43
@ArniStarkware ArniStarkware changed the title chore(batcher): set use_kzg_da flag in build block input chore(starknet_batcher): set use_kzg_da flag in build block input Dec 1, 2024
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from ef924ab to f3ada2d Compare December 1, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from f3ada2d to f84a046 Compare December 1, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants