Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): add height as input #2339

Open
wants to merge 1 commit into
base: arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info@9d77f07). Learn more about missing BASE report.

Additional details and impacted files
@@                                              Coverage Diff                                               @@
##             arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info    #2339   +/-   ##
==============================================================================================================
  Coverage                                                                               ?   17.75%           
==============================================================================================================
  Files                                                                                  ?      119           
  Lines                                                                                  ?    13870           
  Branches                                                                               ?    13870           
==============================================================================================================
  Hits                                                                                   ?     2462           
  Misses                                                                                 ?    11137           
  Partials                                                                               ?      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info branch from e1a8da8 to f632fef Compare November 28, 2024 15:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch from 7de50f1 to 3021db8 Compare November 28, 2024 15:34
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


a discussion (no related file):
This should be part of the previous PR IMO.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/proposal_block_input/add_thin_block_info branch from f632fef to 9d77f07 Compare December 1, 2024 12:31
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch from 3021db8 to b8050db Compare December 1, 2024 12:31
@ArniStarkware ArniStarkware changed the title chore(batcher): add height as input chore(starknet_batcher): add height as input Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants