Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockifier): move block info to starknet api #2246

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore(blockifier): move block info to starknet api #2246

merged 1 commit into from
Nov 28, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Nov 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 24, 2024
Merged
Merged
Merged
@ArniStarkware ArniStarkware marked this pull request as ready for review November 24, 2024 12:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

Artifacts upload workflows:

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.89%. Comparing base (e3165c4) to head (41313e7).
Report is 621 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/block.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2246       +/-   ##
===========================================
+ Coverage   40.10%   54.89%   +14.78%     
===========================================
  Files          26      233      +207     
  Lines        1895    26542    +24647     
  Branches     1895    26542    +24647     
===========================================
+ Hits          760    14569    +13809     
- Misses       1100    10948     +9848     
- Partials       35     1025      +990

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.856 ms 33.921 ms 33.994 ms]
change: [-5.2342% -3.5742% -2.1011%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

alonh5
alonh5 approved these changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

This was referenced Nov 24, 2024
Closed
Closed
Open
Open
alonh5
alonh5 approved these changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

@ArniStarkware ArniStarkware mentioned this pull request Nov 25, 2024
Open
@ArniStarkware ArniStarkware mentioned this pull request Nov 25, 2024
Merged
@ArniStarkware
Copy link
Contributor Author

There is a Python side PR: https://github.com/starkware-industries/starkware/pull/36330.
We want to ensure none of the changes on this stack are blocking.

@ArniStarkware ArniStarkware force-pushed the arni/block_info/move_to_snapi branch 2 times, most recently from 1153ca9 to 697d4e0 Compare November 28, 2024 07:56
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.216 ms 34.688 ms 35.256 ms]
change: [+1.2347% +2.4726% +4.1451%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) high mild
8 (8.00%) high severe

alonh5
alonh5 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch 2 times, most recently from 7669ae6 to 4444d1b Compare November 28, 2024 09:57
@ArniStarkware ArniStarkware changed the base branch from arni/gas_prices/move_to_snapi to graphite-base/2246 November 28, 2024 10:18
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2246 to main November 28, 2024 10:18
ArniStarkware
ArniStarkware commented Nov 28, 2024
View reviewed changes
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

@ArniStarkware ArniStarkware merged commit 50403e4 into main Nov 28, 2024
23 checks passed
@ArniStarkware Graphite App
Copy link
Contributor Author

Merge activity

  • Nov 28, 5:43 AM EST: A user merged this pull request with Graphite.

This was referenced Nov 28, 2024
Open
Open
Open
Open
Open
Open
@ArniStarkware ArniStarkware deleted the arni/block_info/move_to_snapi branch November 28, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonh5 alonh5 alonh5 approved these changes

@aner-starkware aner-starkware Awaiting requested review from aner-starkware

@dorimedini-starkware dorimedini-starkware Awaiting requested review from dorimedini-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @alonh5