Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batcher): remove block metadata member from block builder factory #2230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Nov 21, 2024

Refactor towards getting block info from consensus.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 5.18%. Comparing base (e3165c4) to head (e221112).
Report is 551 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher/src/block_builder.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2230       +/-   ##
==========================================
- Coverage   40.10%   5.18%   -34.93%     
==========================================
  Files          26     146      +120     
  Lines        1895   16974    +15079     
  Branches     1895   16974    +15079     
==========================================
+ Hits          760     880      +120     
- Misses       1100   16020    +14920     
- Partials       35      74       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants