Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batcher): verify block number on propose block #2340

Open
wants to merge 1 commit into
base: arni/batcher/block_builder_factory/set_height_as_proposal_input
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.37%. Comparing base (3021db8) to head (7fc654e).

Files with missing lines Patch % Lines
crates/starknet_batcher/src/batcher.rs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                         @@
##           arni/batcher/block_builder_factory/set_height_as_proposal_input   #2340       +/-   ##
===================================================================================================
- Coverage                                                            17.74%   5.37%   -12.38%     
===================================================================================================
  Files                                                                  119     145       +26     
  Lines                                                                13874   17092     +3218     
  Branches                                                             13874   17092     +3218     
===================================================================================================
- Hits                                                                  2462     918     -1544     
- Misses                                                               11141   16112     +4971     
+ Partials                                                               271      62      -209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch from 7de50f1 to 3021db8 Compare November 28, 2024 15:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 9ad8065 to 7fc654e Compare November 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants