-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(batcher): verify block number on propose block #2340
Open
ArniStarkware
wants to merge
1
commit into
arni/batcher/block_builder_factory/set_height_as_proposal_input
Choose a base branch
from
arni/batcher/propose_block/verify/block_number
base: arni/batcher/block_builder_factory/set_height_as_proposal_input
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arni/batcher/block_builder_factory/set_height_as_proposal_input #2340 +/- ##
===================================================================================================
- Coverage 17.74% 5.37% -12.38%
===================================================================================================
Files 119 145 +26
Lines 13874 17092 +3218
Branches 13874 17092 +3218
===================================================================================================
- Hits 2462 918 -1544
- Misses 11141 16112 +4971
+ Partials 271 62 -209 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 28, 2024
ArniStarkware
force-pushed
the
arni/batcher/block_builder_factory/set_height_as_proposal_input
branch
from
November 28, 2024 15:34
7de50f1
to
3021db8
Compare
ArniStarkware
force-pushed
the
arni/batcher/propose_block/verify/block_number
branch
from
November 28, 2024 15:34
9ad8065
to
7fc654e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.