Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2023 01 17.1.f4e71a7 #739

Merged
merged 62 commits into from
Jan 17, 2023
Merged

Release 2023 01 17.1.f4e71a7 #739

merged 62 commits into from
Jan 17, 2023

Conversation

dhaus67
Copy link

@dhaus67 dhaus67 commented Jan 17, 2023

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

kovayur and others added 30 commits December 12, 2022 16:51
@kovayur
Prepare CHANGELOG for the next release (#663)
debf507
@dependabot
Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 in /tools (#661)
66f4f64 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.5.1...v2.6.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.146 to 1.44.157 (#658)
259e985 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.146 to 1.44.157.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.146...v1.44.157)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/oauth2 from 0.2.0 to 0.3.0 (#659)
91abb9b 
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/golang/oauth2/releases)
- [Commits](golang/oauth2@v0.2.0...v0.3.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ivan-degtiarenko
ROX-12137: Use billing_marketplace_account instead of cloud_account_id (
f3c11d5 
#634)
@kovayur
Increase operator container wait timeout on Openshift CI (#666)
1f54638
@ivan-degtiarenko
ROX-12763: use claim mappings for admin:org:all role (#665)
95ff81e
@kovayur
Fix dnf metadata download errors on Openshift CI (#669)
0f4c60f
@kovayur
Bump containerd version to 1.6.12 (#670)
162e105
@dependabot @kovayur
Bump helm.sh/helm/v3 from 3.9.4 to 3.10.2 (#578)
5eb8b54 
* Bump helm.sh/helm/v3 from 3.9.4 to 3.10.2

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.9.4 to 3.10.2.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.9.4...v3.10.2)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove unused class to fix deps incopatibility

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yury Kovalev <[email protected]>
@stehessel
Deploy probe image based on HEAD (#664)
0bc1c6e
@dependabot
Bump github.com/operator-framework/api from 0.17.1 to 0.17.2 (#660)
93c90c5 
Bumps [github.com/operator-framework/api](https://github.com/operator-framework/api) from 0.17.1 to 0.17.2.
- [Release notes](https://github.com/operator-framework/api/releases)
- [Changelog](https://github.com/operator-framework/api/blob/master/RELEASE.md)
- [Commits](operator-framework/api@v0.17.1...v0.17.2)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kovayur
Second attempt to upgrade containerd dependency (#671)
7cd3dcc
@dependabot
Bump sigs.k8s.io/controller-runtime from 0.12.3 to 0.13.1 (#553)
5bfe2cc 
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.12.3 to 0.13.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.12.3...v0.13.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@porridge
ROX-13396: Cleanup incomplete tools_venv dir for idempotence (#668)
2e34821
@stehessel
ROX-13593: Add telemetry storage key to Centrals (#672)
9d72d52 
* ROX-13593: Add telemetry storage key to Centrals

* separate telemetry config struct
@stehessel
default telemetry options to empty string (#673)
31613af
@stehessel
ROX-13106: Show hint to user when OCM user or org is not found (#675)
cd1083c 
show hint to user when OCM user or org is not found
@kovayur
ROX-13456: Use moq for DBClient (#677)
b1fb9ed
@stehessel
Switch stage data plane to stage operator (#676)
acb691b 
The motivation behind this change is to test our new telemetry feature in the field.
@ivan-degtiarenko
ROX-12921: Introduce timeout for ACSCS requests (#667)
62a3c4a
@dependabot
Bump helm.sh/helm/v3 from 3.9.4 to 3.10.3 in /dp-terraform/add-on/rha…
c83c892 
…cs-terraform (#682)

Bump helm.sh/helm/v3 in /dp-terraform/add-on/rhacs-terraform

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.9.4 to 3.10.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.9.4...v3.10.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@porridge
Avoid using which (#686)
a5662e2 
* Use a portable way to check for pre-commit.
The Mac version of which has an -s option, but the GNU one does not.
* Eradicate all other uses of which.
@dependabot
Bump helm.sh/helm/v3 from 3.10.2 to 3.10.3 (#685)
ff066fc 
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.10.2 to 3.10.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.10.2...v3.10.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kovayur
Make tools_venv target depend on tools/requirements.txt (#688)
6dc12b2
@kovayur
ROX-13456: Refactor fleet-manager client in order to generate mocks f…
e10f3c1 
…or all kinds of APIs (#678)
@dependabot
Bump github.com/getsentry/sentry-go from 0.15.0 to 0.16.0 (#693)
c8ef6db 
Bumps [github.com/getsentry/sentry-go](https://github.com/getsentry/sentry-go) from 0.15.0 to 0.16.0.
- [Release notes](https://github.com/getsentry/sentry-go/releases)
- [Changelog](https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-go@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: github.com/getsentry/sentry-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@parametalol
Fix: avoid panic on nil pointer (#692)
351e2ed 
Hot fix for a panic on nil pointer.
@dependabot
Bump github.com/segmentio/chamber/v2 from 2.10.12 to 2.11.0 in /tools (…
742acea 
…#698)

Bumps [github.com/segmentio/chamber/v2](https://github.com/segmentio/chamber) from 2.10.12 to 2.11.0.
- [Release notes](https://github.com/segmentio/chamber/releases)
- [Changelog](https://github.com/segmentio/chamber/blob/master/Makefile.release)
- [Commits](segmentio/chamber@v2.10.12...v2.11.0)

---
updated-dependencies:
- dependency-name: github.com/segmentio/chamber/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/onsi/gomega from 1.24.1 to 1.24.2 (#694)
7e132dc 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.1 to 1.24.2.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.24.1...v1.24.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 20 commits January 4, 2023 14:38
@dependabot
Bump sigs.k8s.io/controller-runtime from 0.13.1 to 0.14.1 (#706)
b6b48d9 
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.13.1 to 0.14.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.13.1...v0.14.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/spyzhov/ajson from 0.7.1 to 0.7.2 (#703)
a2ffb00 
Bumps [github.com/spyzhov/ajson](https://github.com/spyzhov/ajson) from 0.7.1 to 0.7.2.
- [Release notes](https://github.com/spyzhov/ajson/releases)
- [Commits](spyzhov/ajson@v0.7.1...v0.7.2)

---
updated-dependencies:
- dependency-name: github.com/spyzhov/ajson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kovayur
ROX-13456: Fail fast if cluster configuration is incorrect (#681)
89d811a
@stehessel
Bump stage Central version to nightly-2023-01-09 build (#717)
1553ab7 
Update stage environment to include latest Central version. In
particular, we want to test the telemetry feature, which requires a fix
not included in the currently deployed version.
@dependabot
Bump github.com/openshift-online/ocm-sdk-go from 0.1.289 to 0.1.306 (#…
711203f 
…712)

Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.289 to 0.1.306.
- [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases)
- [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md)
- [Commits](openshift-online/ocm-sdk-go@v0.1.289...v0.1.306)

---
updated-dependencies:
- dependency-name: github.com/openshift-online/ocm-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump gorm.io/driver/postgres from 1.4.5 to 1.4.6 (#713)
324e8b0 
Bumps [gorm.io/driver/postgres](https://github.com/go-gorm/postgres) from 1.4.5 to 1.4.6.
- [Release notes](https://github.com/go-gorm/postgres/releases)
- [Commits](go-gorm/postgres@v1.4.5...v1.4.6)

---
updated-dependencies:
- dependency-name: gorm.io/driver/postgres
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/coreos/go-oidc/v3 from 3.4.0 to 3.5.0 (#714)
c490891 
Bumps [github.com/coreos/go-oidc/v3](https://github.com/coreos/go-oidc) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/coreos/go-oidc/releases)
- [Commits](coreos/go-oidc@v3.4.0...v3.5.0)

---
updated-dependencies:
- dependency-name: github.com/coreos/go-oidc/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/net from 0.4.0 to 0.5.0 (#715)
ac6adb2 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](golang/net@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stehessel
Bump stage Central version to nightly-2023-01-10 build (#719)
827fa8f
@ivan-degtiarenko
ROX-13408: Use api.iam.clients in dynamic clients API wrapper (#689)
75a5e43
@vladbologa
ROX-13666: Refactor DB connection string (#722)
96a8b44
@ivan-degtiarenko
ROX-12921: initialize counter metrics with 0 value (#720)
3d62108
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.172 to 1.44.180 (#724)
506b619 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.172 to 1.44.180.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.172...v1.44.180)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/operator-framework/api from 0.17.2 to 0.17.3 (#725)
93900a3 
Bumps [github.com/operator-framework/api](https://github.com/operator-framework/api) from 0.17.2 to 0.17.3.
- [Release notes](https://github.com/operator-framework/api/releases)
- [Changelog](https://github.com/operator-framework/api/blob/master/RELEASE.md)
- [Commits](operator-framework/api@v0.17.2...v0.17.3)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/openshift-online/ocm-sdk-go from 0.1.306 to 0.1.308 (#…
edf2735 
…726)

Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.306 to 0.1.308.
- [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases)
- [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md)
- [Commits](openshift-online/ocm-sdk-go@v0.1.306...v0.1.308)

---
updated-dependencies:
- dependency-name: github.com/openshift-online/ocm-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stehessel
ROX-12344: Add organisation name to central request (#683)
21f594d 
* ROX-12344: Add organisation name to central request

* check for nil connection

* remove unnecessary nil check

* remove 'new' in message

* check for empty org name

* add external id to error msg

* Migrate org name col of existing records

The org name is queried from AMS in the gorm migration function. To make
this work, the AMS client is injected into the migrations module. If the
OCM_ENV is set to a mocked environment, then org names default to empty
strings.

* nits

* add error handlings to fix linter

* add error handling to scan rows

* mount fleet-manager credentials
@dependabot
Bump github.com/prometheus/common from 0.38.0 to 0.39.0 (#727)
187dd43 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.38.0 to 0.39.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.38.0...v0.39.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dhaus67
Bump operator version to 3.73.1 on prod (#735)
fd09c38
@dhaus67
Bump operator to 3.73.1 in test environment (#737)
50b63bb
@dhaus67
Revert "ROX-12344: Add organisation name to central request" (#736)
f4e71a7 
Revert "ROX-12344: Add organisation name to central request (#683)"

This reverts commit 21f594d.
@dhaus67 dhaus67 temporarily deployed to development January 17, 2023 18:55 — with GitHub Actions Inactive
ivan-degtiarenko
ivan-degtiarenko approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@ivan-degtiarenko ivan-degtiarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaus67, ivan-degtiarenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaus67,ivan-degtiarenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaus67 dhaus67 merged commit ae70193 into production Jan 17, 2023
@dhaus67 dhaus67 deleted the release-2023-01-17.1.f4e71a7 branch January 17, 2023 19:05
kovayur pushed a commit that referenced this pull request Jan 17, 2024
@dhaus67
Release 2023 01 17.1.f4e71a7 (#739)
cac94a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-degtiarenko ivan-degtiarenko ivan-degtiarenko approved these changes

Assignees

@ivan-degtiarenko ivan-degtiarenko

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dhaus67 @ivan-degtiarenko @kovayur @stehessel @porridge @parametalol @vladbologa