-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-12137: Use billing_marketplace_account instead of cloud_account_id #634
ROX-12137: Use billing_marketplace_account instead of cloud_account_id #634
Conversation
} | ||
hasGenericMarketplace = hasGenericMarketplace || rr.BillingModel() == string(amsv1.BillingModelMarketplace) | ||
hasMarketplaceAWS = hasMarketplaceAWS || rr.BillingModel() == string(amsv1.BillingModelMarketplaceAWS) | ||
hasStandardMarketplace = hasStandardMarketplace || rr.BillingModel() == string(amsv1.BillingModelStandard) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this variable? Generic and standard are too similar, and the standard billing model does not have any marketplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend at least testing the telemeter labels once before merging. Otherwise lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivan-degtiarenko, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1ee67b0
to
cb99f50
Compare
New changes are detected. LGTM label has been removed. |
Description
To get AMS to bill the cloud account, we need to use
billing_marketplace_account
instead ofcloud_account_id
parameter.Links:
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts