Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch stage data plane to upstream operator #676

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

stehessel
Copy link
Contributor

Description

The motivation behind this change is to test our new telemetry feature in the field.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

The motivation behind this change is to test our new telemetry feature in the field.
@stehessel stehessel requested review from kovayur and a team December 15, 2022 12:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -32,12 +32,15 @@ case $ENVIRONMENT in
FM_ENDPOINT="https://xtr6hh3mg6zc80v.api.stage.openshift.com"
OBSERVABILITY_GITHUB_TAG="master"
OBSERVABILITY_OBSERVATORIUM_GATEWAY="https://observatorium-mst.api.stage.openshift.com"
OPERATOR_USE_UPSTREAM="true"
OPERATOR_VERSION="v3.73.0-nightly-20221215"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who and when will update this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be updated manually by the acscs release manager - similar to how we already handle OPERATOR_VERSION, stage should run a more recent version than prod. The difference is that now we can also run version in-between official releases.

@stehessel stehessel merged commit acb691b into main Dec 15, 2022
@stehessel stehessel deleted the switch-stage-to-upstream-acs-operator branch December 15, 2022 17:54
@stehessel stehessel changed the title Switch stage data plane to stage operator Switch stage data plane to upstream operator Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants