Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy probe image based on HEAD #664

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

stehessel
Copy link
Contributor

Description

The probe image should be set dynamically based on the current main / production branch state, similar to what we do for fleetshard-sync. This problem was surfaced by this alert https://redhat.pagerduty.com/incidents/Q2NJKU6OY1J9RT. The latest probe image contains a change to the timeout value (15min -> 30min), which will be deployed.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@stehessel stehessel assigned ebensh and unassigned ebensh Dec 12, 2022
@stehessel stehessel requested a review from ebensh December 12, 2022 15:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, porridge, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johannes94,porridge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel force-pushed the probe/set-image-based-on-head branch from be847b4 to b25851d Compare December 13, 2022 10:37
@openshift-ci openshift-ci bot removed the lgtm label Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

New changes are detected. LGTM label has been removed.

@stehessel
Copy link
Contributor Author

Rebased to main after #666 landed, let's see if it fixes the end2end test.

@stehessel stehessel force-pushed the probe/set-image-based-on-head branch from b25851d to 7146e37 Compare December 13, 2022 15:06
@stehessel stehessel merged commit 0bc1c6e into main Dec 13, 2022
@stehessel stehessel deleted the probe/set-image-based-on-head branch December 13, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants