Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-13408: Use api.iam.clients in dynamic clients API wrapper #689

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

ivan-degtiarenko
Copy link
Contributor

@ivan-degtiarenko ivan-degtiarenko commented Dec 16, 2022

Description

Switch to explicitly requesting api.iam.clients scope when getting token for sso.redhat.com dynamic clients API. Currently, the scope is being returned by default.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

  1. Created local fleet-manager with dynamic client configuration
  2. POST new central
  3. Verified that db contains central with client id and client secret

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ivan-degtiarenko ivan-degtiarenko marked this pull request as ready for review January 11, 2023 12:31
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development January 11, 2023 12:31 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-degtiarenko, rukletsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivan-degtiarenko
Copy link
Contributor Author

/retest

@ivan-degtiarenko ivan-degtiarenko merged commit 75a5e43 into main Jan 11, 2023
@ivan-degtiarenko ivan-degtiarenko deleted the ivan/ROX-13408-use-api.iam.clients-scope branch January 11, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants