-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 1 to master #52
Open
pinterid
wants to merge
352
commits into
master
Choose a base branch
from
implement-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+11,495
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is possible to upload and delete talks.
The site title has been changed to SNEK.
The talkspage is displayed now.
Now only the globalFunctions and globalState are passed as props.
Code quality has been improved
Suggestions from @pinterid and @schettn are applied now. Co-authored-by: Pinterics David <[email protected]>
The mount condition has been refined and simplified.
The code quality was improved due to request by Codacy.
The code quality was improved due to a request by Codacy.
The code quality was improved due to a request by Codacy.
The code quality was improved due to a request by @kleberbaum. Co-authored-by: Florian Kleber <[email protected]>
The site title was changed due to a request by @kleberbaum. Co-authored-by: Florian Kleber <[email protected]>
Add heart aa1 to implement 1
A searchbar is created now. The searchbar is added to the navbar now.
Now it is possible to fetch all snek users.
Fuzzysort framework is used to search in users.
The code quality was improved due to a request by @pinterid.
Suggestions of @schettn are applied now.
Add search aa1 to implement 1
pinterid
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jun 7, 2020
The code quality was improved due to a request by Codacy.
Now all TSID anchors have an ID
The troubleshooting messages of all TSIDs have been updated.
The latest activity now refreshes after re-caching.
The total contributions of the 3D calendar now change depending on the selected year.
The Mail field is now a required field.
It is now not possible to save the changes if the Mail field is empty.
The code quality was improved due to a request by @Aichnerc.
The code quality was improved due to a request by @schettn. Co-authored-by: Schett Nico <[email protected]>
The profile information is now displayed correctly.
The code quality was improved due to a request by @kleberbaum. Co-authored-by: Florian Kleber <[email protected]>
The code quality was improved. Co-authored-by: Florian Kleber <[email protected]>
Improve overview aa1 to implement 1
Improve settings ba1 to implement 1
Due to an error, incorrect login attempts were ignored and ended in a redirection to ./u/undefined. By improving the session.begin() response, this problem is resolved.
The profile task no longer accepts usernames in <u_<username>>, instead <username>.
Now only a authenticated not anonymous real user can login.
A dispatch has been replaced with error raising which will be catched by the correct dispatcher.
The structure of cache has been refined.
The console logs were removed from the changes.
The Anexia logo was added to the assets.
The Netcup logo was added to the assets.
The stylesheet for sponsors was added.
The sponsor section was added.
The export for sections was combined into one file.
The sponsor section is no imported in the homepage.
The sponsor section was implemented.
Migrate snekclientv2 aa2 to implement 1
Add sponsorssection aa1 to implement 1
The correct version of intel and client has been added in order to run this app.
The content of the sponsor text has been adjusted.
The code quality was improved due to a request by @kleberbaum.
Add sponsorssection aa2 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
Currently there is no 2D calendar chart. There should be a 2D Calendar Chart #17
Currently there is no 3D calendar chart. There should be a 3D Calendar Chart #18
Currently there is no contribution radar chart. There should be a ContributionRadar Chart #19
Currently there is no latest activity chart. There should be a LatestActivity Chart #20
Now there is a 2D calendar chart. Closes There should be a 2D Calendar Chart #17
Now there is a 3D calendar chart. Closes There should be a 3D Calendar Chart #18
Now there is a contribution radar chart. Closes There should be a ContributionRadar Chart #19
Now there is a latest activity chart. Closes There should be a LatestActivity Chart #20
Currently when reloading or switching a page it starts not on top of the page. When reloading or switching a page it should start at the beginning of page #14
Currently there is no project component. There should be a project component #15
Currently there is no component for pinned items. There should be a pinned item component #16
Now the spawn point of a page is on top. Closes When reloading or switching a page it should start at the beginning of page #14
Now there is a project component which could display several repository data. Closes There should be a project component #15
Now there is a component for pinned items. Closes There should be a pinned item component #16
Currently there is no footer component. There should be a Footer component #21
Currently there is no navbar component. There should be a Navbar component #22
Currently there is no login form component. There should be a LoginForm component #23
Currently there is no register form component. There should be a RegisterForm component #24
Currently there is no upload modal component. There should be a UploadModal component #25
Currently there is no user action card component. There should be a UserActionCard component #26
Now there is a footer component. Closes There should be a Footer component #21
Now there is a navbar component. Closes There should be a Navbar component #22
Now there is a login form component. Closes There should be a LoginForm component #23
Now there is a register form component. Closes There should be a RegisterForm component #24
Now there is a upload modal component. Closes There should be a UploadModal component #25
Now there is a user action card component. Closes There should be a UserActionCard component #26
Currently there is no overview tab. There should be a overview tab #30
Currently there is no projects tab. There should be a projects tab #31
Currently there is no talks tab. There should be a talks tab #32
Currently there is no organism that contains all tabs. There should be a organism which contains all tabs #33
Currently there is no profile info organism. There should be a profile info organism #34
Currently there is no organism which contains all other organism related to a software engineer. There should be a organism which contains all other organism related to a software engineer #35
Now there is a overview tab. Closes There should be a overview tab #30
Now there is a projects tab. Closes There should be a projects tab #31
Now there is a talks tab. Closes There should be a talks tab #32
Now there is a organism that contains all tabs. Closes There should be a organism which contains all tabs #33
Now there is a profile info organism. Closes There should be a profile info organism #34
Now there is a organism which contains all other organism related to a software engineer. Closes There should be a organism which contains all other organism related to a software engineer #35
Currently there is no companypage. There should be a companypage #37
Now there is a companypage. Closes There should be a companypage #37
Currently there is no homepage. There should be a homepage #38
Now there is a homepage. Closes There should be a homepage #38
Currently there is no profilepage. There should be a profilepage #39
Now there is a profilepage. Closes There should be a profilepage #39
Currently there is no talkpage. There should be a talkpage #40
Now there is a talkpage. Closes There should be a talkpage #40
Currently there are no authentication methods. There should be authentication methods #45
Currently there are no registration methods. There should be registration methods #46
Currently there are no data handling methods. There should be data handling methods #47
Currently there is no fitting site title. There should be a fitting site title #48
Now there are authentication methods. Closes There should be authentication methods #45
Now there are registration methods. Closes There should be registration methods #46
Now there are data handling methods. Closes There should be data handling methods #47
Now there is a fitting site title. Closes There should be a fitting site title #48
Currently there is no atom for SearchBar. There should be a SearchBar atom #50
Now there is an atom for SearchBar. Closes There should be a SearchBar atom #50
Currently the router structure does not fit our needs. There should be an improvement to the react router structure #54
Currently the SearchBar closes when clicking on the search label. The SearchBar closes when clicking on the search label #55
Currently snek-intel:v0.1.0 is used which produces an error when generating talks. Upgrade snek-intel to v0.1.1 #56
Currently there is no .env.template file. There should be a template file for .env #57
Currently there are no regions inside the App component. There should be regions in the App component to separate the methods #58
Currently react-scripts:v3.0.1 is used which has some security vulnerabilities. Upgrade react-scripts to v3.4.1 #59
Currently the SearchBar does not use the history API to switch profiles. The SearchBar does not use the browser history API #60
Currently some parts of the code uses the wrong notation for the username inside of platformData. Some code uses platformData.user.username #61
Currently it is not possible to switch a profile page while caching is ongoing. When switching the profile page while caching yours the cache gets fucked up #62
Now the router structure do fit our needs. Closes There should be an improvement to the react router structure #54
Now the SearchBar works fine. The label is removed now and therefore it is not possible to click on it.. It does not close :). Closes The SearchBar closes when clicking on the search label #55
Now snek-intel:v0.1.1 is used. Therefore there are no more issues related to talk generation. Closes Upgrade snek-intel to v0.1.1 #56
Now there is a .env.template file. Closes There should be a template file for .env #57
Now there are regions to separate methods in the App component. Closes There should be regions in the App component to separate the methods #58
Now react-scripts:v3.0.1 is used and the security vulnerabilities are fixed. Closes Upgrade react-scripts to v3.4.1 #59
Now the SearchBar uses the history API. Closes The SearchBar does not use the browser history API #60
Now the correct notation for the platformData username is used. Closes Some code uses platformData.user.username #61
Now it is possible to switch the profile page while caching your own profile. Closes When switching the profile page while caching yours the cache gets fucked up #62
Currently all logic is located in the
App.js
which produces a lot of mess. There is no folder structure for helpers #64Currently routing does not work well on static file servers. Routing issue on deployment GhPages #66
Now logic is split into separate actions.
App.js
only fulfils the purpose of setting main states. Closes There is no folder structure for helpers #64Now routing works even on static file servers. Closes Routing issue on deployment GhPages #66
Currently the active tab of a software profile is not remembered. The active tab should be remembered #72
Currently the sign in button in the navigation bar redirects to the start page, but not directly to the sing in form. The navbar login button should redirect to the login form #73
Currently it is not possible to upload custom avatar images. There should be a way to upload a profile picture #76
Currently user settings can be changed via a modal. The settings modal should be changed to a settings page #77
Currently when recaching data the avatar image resets. The settings action does not support avatar url updates #78
Currently the application structure does not fit our needs because several issues. The application structure should be enhanced by using redux #80
Currently there is no notification when sining in fails. There should be a notification when something gone wrong when logging in #81
Currently the pinned repositories are kind of useless because they do not show any useful information. The pinned projects should be temporary disabled #82
Currently there are some issues in styling when displaying projects. There are some issues with displaying projects #83
Currently there is no language chart for projects. There should be a language chart for each project #84
Currently there is no default image for projects without an avatar image/owner. There should be a default image for projects without an avatar #85
Currently there is no language chart for a user. There should be a language chart in profile info #86
Currently a user cannot modify the position of charts on his own overview page. There should be a editor mode for the overview tab #88
Currently the design seems a bit outdated and there are several minor issues. The design should be improved #90
Now the active tab of a software profile is remembered. Closes The active tab should be remembered #72
Now the navbar login button redirects to the login form. Closes The navbar login button should redirect to the login form #73
Now it is possible to upload custom avatar images. Closes There should be a way to upload a profile picture #76
Now user settings can be changed via a separate settings page. Closes The settings modal should be changed to a settings page #77
Now when uploading a avatar image it is permanent. Closes The settings action does not support avatar url updates #78
Now redux is implemented which resolves issues like active tabs when state changes,.. Closes The application structure should be enhanced by using redux #80
Now when singing in fails there is a notification in the login form. Closes There should be a notification when something gone wrong when logging in #81
Now the pinned repositories are temporary disabled. Closes The pinned projects should be temporary disabled #82
Now the styling of projects is refined and also works fine with projects without an owner. Closes There are some issues with displaying projects #83
Now there is a language chart for each project. Closes There should be a language chart for each project #84
Now there is a default image for projects without a an avatar/owner. Closes There should be a default image for projects without an avatar #85
Now there is a language chart on each user profile. Closes There should be a language chart in profile info #86
Now a user can modify the position of charts on his own overview page. Closes There should be a editor mode for the overview tab #88
Now the design is more rounded and improved in general. Project styling, navbar styling,.. has been updated. Closes The design should be improved #90
Other information:
The introduced code complies with tonic standard.
Ref: https://githb.com/snek-at/tonic/