Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no folder structure for helpers #64

Open
pinterid opened this issue Jun 11, 2020 · 1 comment · Fixed by #65 · May be fixed by #52
Open

There is no folder structure for helpers #64

pinterid opened this issue Jun 11, 2020 · 1 comment · Fixed by #65 · May be fixed by #52
Assignees
Labels
enhancement New feature or request

Comments

@pinterid
Copy link
Member

pinterid commented Jun 11, 2020

Describe the feature or change you'd like

It sould be discussed, if a folder for helpers should be made which would contain most of those functions - only to be imported into the App.js to be appended to globalFunctions.

I think this is a good way to go. But is this relevant to v0.1.0? @snek-at/frontend

I would certainly appreciate this being part of a very early version to keep building on that solid base, yes.

After merging #63 I will add it.

Originally posted by @schettn in #52

A folder helpers should be created which contains most of the functions imported to "App.js".

@pinterid pinterid added the enhancement New feature or request label Jun 11, 2020
@schettn
Copy link
Member

schettn commented Jun 11, 2020

I would change the structure in a way where every helper functions which should set a state, returns the value instead. Then the state is set in App.js

@schettn schettn linked a pull request Jun 18, 2020 that will close this issue
7 tasks
@pinterid pinterid linked a pull request Jun 25, 2020 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants