-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add organisms aa1 to implement 1 #36
Conversation
The OverviewTab Component has been added.
The ProjectTab Component has been added.
The TalksTab Component has been added.
A file has been added to import all components to export them for easy access from parent components.
The SoftwareTabs component has been added. It includes several sub tab components.
A profile info component has been added.
The SoftwareEngineer Component has been added.
Import profile component to export it for easy access from parent components.
A newline has been removed
The component has been renamed to SoftwareTabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes have to be made.
Added @pinterid suggestions. Co-authored-by: Pinterics David <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok to merge.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information: