Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organisms aa1 to implement 1 #36

Merged
merged 11 commits into from
Jun 6, 2020
Merged

Add organisms aa1 to implement 1 #36

merged 11 commits into from
Jun 6, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 6, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

schettn added 10 commits June 6, 2020 18:30
The OverviewTab Component
has been added.
The ProjectTab Component
has been added.
The TalksTab Component
has been added.
A file has been added to import all 
components to export them for easy access
from parent components.
The SoftwareTabs component has been
added. It includes several sub tab components.
A profile info component has been
added.
The SoftwareEngineer Component has
been added.
Import profile component to export it
for easy access from parent components.
A newline has been removed
The component has been renamed to SoftwareTabs
@pinterid pinterid added the enhancement New feature or request label Jun 6, 2020
@pinterid pinterid added this to the SNEK Version 0.1.0 milestone Jun 6, 2020
@pinterid pinterid self-assigned this Jun 6, 2020
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes have to be made.

src/components/organisms/tabs/OverviewTab/index.jsx Outdated Show resolved Hide resolved
Added @pinterid suggestions.

Co-authored-by: Pinterics David <[email protected]>
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@schettn schettn merged commit ecacab9 into implement-1 Jun 6, 2020
@pinterid pinterid mentioned this pull request Jun 7, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants