Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add molecules aa1 to implement 1 #29

Merged
merged 19 commits into from
Jun 6, 2020
Merged

Add molecules aa1 to implement 1 #29

merged 19 commits into from
Jun 6, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 6, 2020 •
edited by schettn
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

@schettn
Add Footer Component
094a5f7 
The footer component has been added.
It is not displayed yet.
@schettn
Add Navbar Component
b964cda 
The navbar component has been added.
It is not displayed yet.
@schettn
Add LoginForm Component
a3becbb 
The login form component has been added.
It is not displayed yet.
@schettn
Add RegisterForm Component
8b72dfd 
The login form component has been added.
It is not displayed yet. snek-intel has been added
but currently only as local package.
@schettn
Add UploadModal Component
63efd53 
The upload modal component has been added.
It is not displayed yet.
@schettn
Add UserActionCard Component
7fe6de3 
The useractioncard modal component has been added.
It is not displayed yet.
@schettn
Remove unused imports
79f5fc5 
All imports which are currently not used
are removed now.
@schettn
Add assets
b4efab6 
Assests for the footer, navbar and userActionCard
has been added.
@pinterid pinterid added the enhancement New feature or request label Jun 6, 2020
@pinterid pinterid added this to the SNEK Version 0.1.0 milestone Jun 6, 2020
@pinterid pinterid requested a review from schettn June 6, 2020 13:31
@pinterid pinterid self-assigned this Jun 6, 2020
@schettn
Improve code quality
c164d87 
The code quality has been improved
due to a request of Codacy.
schettn
schettn requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions.

src/components/molecules/Footer/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/Footer/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/Navbar/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/Navbar/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/UserActionCard/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/UserActionCard/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/modals/UploadModal/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/modals/UploadModal/index.jsx Show resolved Hide resolved
src/components/molecules/modals/UploadModal/index.jsx Show resolved Hide resolved
schettn and others added 2 commits June 6, 2020 15:58
@schettn
Apply suggestions from code review
5b8e8aa 
All suggestions are implemented now.
@schettn
Improve code quality
eab6a68 
Some newlines have been added.
@schettn schettn self-requested a review June 6, 2020 14:00
schettn
schettn approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pinterid
Improve code quality
c44d2b5 
The code quality has been improved due to a request by Codacy.
@pinterid
Merge remote-tracking branch 'origin/add-molecules-aa1' into add-mole…
422d317 
…cules-aa1
pinterid
pinterid commented Jun 6, 2020
View reviewed changes
Copy link
Member Author

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes have to be done.

src/components/molecules/Footer/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/forms/LoginForm/index.jsx Show resolved Hide resolved
src/components/molecules/forms/LoginForm/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Show resolved Hide resolved
schettn and others added 3 commits June 6, 2020 16:55
@schettn @pinterid
Apply suggestions from code review
b9c9392 
Some suggestions have been implemented.

Co-authored-by: Pinterics David <[email protected]>
@schettn
Improve code quality
dde3c5f 
The code quality has been improved 
due to a request of @pinterid.
@pinterid
Improve code quality
13ea5b4 
The code quality was improved due to a request by Codacy.
@kleberbaum kleberbaum self-requested a review June 6, 2020 15:11
@pinterid
Improve code quality
4842f88 
The code quality was improved due to a request by Codacy.
kleberbaum
kleberbaum requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

src/components/molecules/forms/LoginForm/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/UserActionCard/useractioncard.scss Outdated Show resolved Hide resolved
src/components/molecules/forms/LoginForm/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Outdated Show resolved Hide resolved
@schettn schettn requested a review from kleberbaum June 6, 2020 15:56
@schettn
Improve code quality
b835a3d 
The code quality has been improved
due to a request of @kleberbaum.
@schettn
Improve code quality
dfd911c 
The code quality has been improved.
kleberbaum
kleberbaum approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@schettn schettn merged commit 62b85fe into implement-1 Jun 6, 2020
@pinterid pinterid mentioned this pull request Jun 7, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schettn schettn schettn approved these changes

@kleberbaum kleberbaum kleberbaum approved these changes

Assignees

@pinterid pinterid

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinterid @kleberbaum @schettn