Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The application structure should be enhanced by using redux #80

Open
schettn opened this issue Jul 4, 2020 · 0 comments · Fixed by #87 · May be fixed by #52
Open

The application structure should be enhanced by using redux #80

schettn opened this issue Jul 4, 2020 · 0 comments · Fixed by #87 · May be fixed by #52
Assignees
Labels
enhancement New feature or request

Comments

@schettn
Copy link
Member

schettn commented Jul 4, 2020

Is your feature request related to a problem? Please describe.
Currently we are using a kind of structure inspired by redux. We have actions which contain the logic and AppJS which sets the states based of the actions responses.

Every time a state gets set in AppJS the whole application reloads. That is not indented and not recommend.
A further problem is that it is very messy to hand over all props correctly.

Describe the solution you'd like
By replacing our structure with redux we eliminate the issue with application reloads and passing over most data as props is not longer required.

@schettn schettn added the enhancement New feature or request label Jul 4, 2020
@schettn schettn added this to the SNEK Version 0.1.0 milestone Jul 4, 2020
@schettn schettn self-assigned this Jul 4, 2020
@schettn schettn linked a pull request Jul 6, 2020 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant