Add redux aa1 to improve basics aa3 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New redux structure was roughly implemented. Refinements take place in the following commits. But .. redux is fun :)
Some bugs are fixed and the actions were adjusted.
Incorrect user fetching has been fixed.
The registration works now with the new structure.
A context error where the login function was not defined due to asynchronously is fixed now. After registering a user will be logged in.
React-Avatar-Editor was added for editing images on the site.
The modal for editing images was added.
The modal imports and exports were updated.
A page for editing user settings was added.
The path for the settings page was set.
The navbar settings now work with the settings page.
The settings action is now capable of updating profile pictures.
Now it is possible to access the settings page directly by entering the url. Access is only granted to the own settings page.
Now when clicking on `My Profile` only the corresponding components are rendered and not longer everyone like before.
Due to the switch to Redux, a lot of code is obsolete and is now being removed.
Now Redux DevTools only applies in development mode.
The resolving of the merge conflicts went wrong and produced a syntax error which is fixed now.
Uploading and deleting of talks is now only possible if a user is signed in and on his profile.
Blank initialization was removed because it is no longer needed.
The check was added to prevent the uncontrolled component warning.
The chart for displaying languages has been added.
The project component has been improved and now actually looks nice.
The language chart and top languages have been implemented.
The pinned posts have been temporarily disabled.
The auth actions errors were updated.
The login form errors were updated.
|
@snek-at/frontend Just have a look on logically errors or some other invalid stuff. Issues on console logs and/or comments like sections are not part of this PR. This is taken care of in implement PR! |
|
Opening the settings page without being logged in should redirect to the login page. Currently there is just an infinity loading screen. |
This was
linked to
issues
Jul 6, 2020
pinterid
reviewed
Jul 6, 2020
pinterid
approved these changes
Jul 6, 2020
The message have been refined cause the old one was a bit shitty.
Now when a anonymous user visits the settings page he is redirected to the homepage with active login form.
|
I have updated the login error message cause it was not very neat to me. |
kleberbaum
approved these changes
Jul 6, 2020
Issues marked by Codacy were resolved.
Issues marked by Codacy were resolved.
Codacy errors were fixed.
Previously some data was stored in the profile section. Therefore when adjusting data in settings it got overwritten during a refetch. By moving this data to user section it does not get overwritten anymore.
Now when the result is undefined nothing happens cause there is no error.
There was an error where it always redirected if the settings url was entered directly. This issue is fixed now,
There was a workaround to update user settings. This is removed now because it resets the user data every read cache iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information: