Arity check for shift and added some warnings #35293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, add/update docstrings
Co-authored-by: Travis Scrimshaw <[email protected]>
Updated the logo to use the svg available at - https://raw.githubusercontent.com/sagemath/artwork/master/bare_logo_sagemath.svg. The original image seems broken while accessing from GitHub's web interface. Please tell me if this works. After careful consideration, I decided not to use the original black logo (at /src/doc/common/static/logo_sagemath_black.svg) due to potential disparities in its visibility when viewed by users with different display settings, such as light and dark modes.
Reported by: seblabbe
The hnf for integer dense matrices is quite slow, reported in sagemath#35161. While that issue is resolved, it doesn't make sense to keep this very slow test, so tune it down to an acceptable time.
…ate docstest to account for the same
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li> <p>This change adds a minimum runner version(node12 -> node16), which can break users using an out-of-date/fork of the runner. This would be most commonly affecting users on GHES 3.3 or before, as those runners do not support node16 actions and they can use actions from github.com via <a href="https://docs.github.com/en/[email protected]/admin/github- actions/managing-access-to-actions-from-githubcom/enabling-automatic- access-to-githubcom-actions-using-github-connect">github connect</a> or manually copying the repo to their GHES instance.</p> </li> <li> <p>Few dependencies and cache action usage examples have also been updated.</p> </li> </ul> <h2>v2.1.7</h2> <p>Support 10GB cache upload using the latest version <code>1.0.8</code> of <a href="https://www.npmjs.com/package/@actions/cache"><code>@actions /cache</code> </a></p> <h2>v2.1.6</h2> <ul> <li>Catch unhandled "bad file descriptor" errors that sometimes occurs when the cache server returns non-successful response (<a href="https://github-redirect.dependabot.com/actions/cache/pull/596" >actions/cache#596</a>)</li> </ul> <h2>v2.1.5</h2> <ul> <li>Fix permissions error seen when extracting caches with GNU tar that were previously created using BSD tar (<a href="https://github-redirect. dependabot.com/actions/cache/issues/527">actions/cache#527</a>)</li> </ul> <h2>v2.1.4</h2> <ul> <li>Make caching more verbose <a href="https://github- redirect.dependabot.com/actions/toolkit/pull/650">sagemath#650</a></li> <li>Use GNU tar on macOS if available <a href="https://github- redirect.dependabot.com/actions/toolkit/pull/701">sagemath#701</a></li> </ul> <h2>v2.1.3</h2> <ul> <li>Upgrades <code>@actions/core</code> to v1.2.6 for <a href="https://github.com/advisories/GHSA- mfwh-5m23-j46w">CVE-2020-15228</a>. This action was not using the affected methods.</li> <li>Fix error handling in <code>uploadChunk</code> where 400-level errors were not being detected and handled correctly</li> </ul> <h2>v2.1.2</h2> <ul> <li>Adds input to limit the chunk upload size, useful for self-hosted runners with slower upload speeds</li> <li>No-op when executing on GHES</li> </ul> <h2>v2.1.1</h2> <ul> <li>Update <code>@actions/cache</code> package to <code>v1.0.2</code> which allows cache action to use posix format when taring files.</li> </ul> <h2>v2.1.0</h2> <ul> <li>Replaces the <code>http-client</code> with the Azure Storage SDK for NodeJS when downloading cache content from Azure. This should help improve download performance and reliability as the SDK downloads files in 4 MB chunks, which can be parallelized and retried independently</li> <li>Display download progress and speed</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/ RELEASES.md">actions/cache's changelog</a>.</em></p> <blockquote> <h1>Releases</h1> <h3>3.0.0</h3> <ul> <li>Updated minimum runner version support from node 12 -> node 16</li> </ul> <h3>3.0.1</h3> <ul> <li>Added support for caching from GHES 3.5.</li> <li>Fixed download issue for files > 2GB during restore.</li> </ul> <h3>3.0.2</h3> <ul> <li>Added support for dynamic cache size cap on GHES.</li> </ul> <h3>3.0.3</h3> <ul> <li>Fixed avoiding empty cache save when no files are available for caching. (<a href="https://github- redirect.dependabot.com/actions/cache/issues/624">issue</a>)</li> </ul> <h3>3.0.4</h3> <ul> <li>Fixed tar creation error while trying to create tar with path as <code>~/</code> home folder on <code>ubuntu-latest</code>. (<a href="https://github- redirect.dependabot.com/actions/cache/issues/689">issue</a>)</li> </ul> <h3>3.0.5</h3> <ul> <li>Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (<a href="https://github- redirect.dependabot.com/actions/cache/pull/834">PR</a>)</li> </ul> <h3>3.0.6</h3> <ul> <li>Fixed <a href="https://github- redirect.dependabot.com/actions/cache/issues/809">sagemath#809</a> - zstd -d: no such file or directory error</li> <li>Fixed <a href="https://github- redirect.dependabot.com/actions/cache/issues/833">sagemath#833</a> - cache doesn't work with github workspace directory</li> </ul> <h3>3.0.7</h3> <ul> <li>Fixed <a href="https://github- redirect.dependabot.com/actions/cache/issues/810">sagemath#810</a> - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour.</li> </ul> <h3>3.0.8</h3> <ul> <li>Fix zstd not working for windows on gnu tar in issues <a href="https://github- redirect.dependabot.com/actions/cache/issues/888">sagemath#888</a> and <a href="https://github- redirect.dependabot.com/actions/cache/issues/891">sagemath#891</a>.</li> <li>Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable <code>SEGMENT_DOWNLOAD_TIMEOUT_MINS</code>. Default is 60 minutes.</li> </ul> <h3>3.0.9</h3> <ul> <li>Enhanced the warning message for cache unavailablity in case of GHES.</li> </ul> <h3>3.0.10</h3> <ul> <li>Fix a bug with sorting inputs.</li> <li>Update definition for restore-keys in README.md</li> </ul> <h3>3.0.11</h3> <ul> <li>Update toolkit version to 3.0.5 to include <code>@actions/core@^1.10.0</code></li> <li>Update <code>@actions/cache</code> to use updated <code>saveState</code> and <code>setOutput</code> functions from <code>@actions/core@^1.10.0</code></li> </ul> <h3>3.1.0-beta.1</h3> <ul> <li>Update <code>@actions/cache</code> on windows to use gnu tar and zstd by default and fallback to bsdtar and zstd if gnu tar is not available. (<a href="https://github- redirect.dependabot.com/actions/cache/issues/984">issue</a>)</li> </ul> <h3>3.1.0-beta.2</h3> <ul> <li>Added support for fallback to gzip to restore old caches on windows.</li> </ul> <h3>3.1.0-beta.3</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="actions/cache@69d9d449aced6a2ede0 bc19182fadc3a0a42d2b0"><code>69d9d44</code></a> Merge pull request <a href="https://github- redirect.dependabot.com/actions/cache/issues/1118">sagemath#1118</a> from actions/pdotl/zstd-hotfix</li> <li><a href="actions/cache@8d3a1e02aa504540dff 5000c782b8263e3b411fb"><code>8d3a1e0</code></a> Fix license</li> <li><a href="actions/cache@b1db4b48979ec1f6d61 42513d9448c4288d05ec4"><code>b1db4b4</code></a> Fix zstd breaking after new version release</li> <li><a href="actions/cache@7d4d6f7ffd301005e7f ac90369bb90ae1d547974"><code>7d4d6f7</code></a> Update package- lock.json</li> <li><a href="actions/cache@8f7fa5d715f6773b40e 9fbf9cb77bcb5d914d0dc"><code>8f7fa5d</code></a> Bump <code>@actions/cache</code> version</li> <li><a href="actions/cache@95b455a0fba5a5e1770 cc10ded51e5fe99a6737b"><code>95b455a</code></a> 3.2.6</li> <li><a href="actions/cache@81b728193625a15a55f cce4c6eb6187358533785"><code>81b7281</code></a> Updated branch in Force deletion of caches (<a href="https://github- redirect.dependabot.com/actions/cache/issues/1108">sagemath#1108</a>)</li> <li><a href="actions/cache@6998d139ddd3e68c71e 9e398d8e40b71a2f39812"><code>6998d13</code></a> Release patch version update (<a href="https://github- redirect.dependabot.com/actions/cache/issues/1105">sagemath#1105</a>)</li> <li><a href="actions/cache@2b8105bdae4b746666e e225970c4a281bbd9d51f"><code>2b8105b</code></a> Fixing paths for OSes (<a href="https://github- redirect.dependabot.com/actions/cache/issues/1101">sagemath#1101</a>)</li> <li><a href="actions/cache@e08330827dd5663b268 018076572bea59a734b60"><code>e083308</code></a> Fixed typos and formatting in docs (<a href="https://github- redirect.dependabot.com/actions/cache/issues/1076">sagemath#1076</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing- security-vulnerabilities/about-dependabot-security-updates#about- compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#35185 Reported by: dependabot[bot] Reviewer(s): Tobias Diez
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description We provide a number of improvements to the Weyl character ring: 1. We make it know that it is commutative (along with its ambient ring). 2. We speedup the `_demazure_helper` method by only doing operations based upon the support of the simple roots. ``` sage: F = FusionRing(['B',10], 2, base_ring=QQ) sage: dd = {(1,0,0,1,0,0,0,0,0,0): 1} sage: %time X = F._demazure_helper(dd) CPU times: user 3.1 s, sys: 12 ms, total: 3.11 s Wall time: 3.11 s ``` Previously took `~6s`. 3. We don't set the `FusionRing` as a subobject of the `WeightRing`. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes sagemath#1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [ ] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: sagemath#35186 Reported by: Travis Scrimshaw Reviewer(s): Dima Pasechnik
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description Add typing information for tangent vectors (and related classes). <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes sagemath#1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [ ] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: sagemath#35189 Reported by: Tobias Diez Reviewer(s): Eric Gourgoulhon
This allows for also using the syntax which sagemath already uses in the output of symbolic derivatives of functions like `D[0,1](f)(x+y,x-y)` in user input. Resolves sagemath#32554 Resolves sagemath#17445 URL: sagemath#35193 Reported by: Marius Gerbershagen Reviewer(s): Eric Gourgoulhon, Matthias Köppe
### 📚 Description When maxima is initialized a bug in ecl implementation of `ensure-directories-exist` might result in a runtime error. As a workaround, in case we get a runtime error we use python to create the directory and continue with maxima initialization. Note that for normal usage the directory will already exist within the user's `DOT_SAGE` so this code will almost never run. However, when running doctests on CI this occasionally triggers. #### New doctest The first commit introduces a doctest to try to catch this race. We run a new instance of sage in a subprocess to ensure maxima is not already initialized. We use a temporary `MAXIMA_USERDIR` so its empty, and we try to initialize maxima twice in parallel to entice the race. This temporary dir is placed within `DOT_SAGE` so it is easy to try different filesystems. The bug triggers more frequently if `DOT_SAGE` is in a high latency filesystem (e.g. sshfs on a non-local host). Closes sagemath#26968. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [x] I have created tests covering the changes. URL: sagemath#35195 Reported by: Gonzalo Tornaría Reviewer(s): Gonzalo Tornaría, Matthias Köppe
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> ### Description Fixes Set inequality (issue sagemath#35178) <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes sagemath#1337" --> ### Changes Details at sagemath#35178 <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies (none) URL: sagemath#35197 Reported by: John H. Palmieri Reviewer(s): Matthias Köppe
…ons`, `importlib_resources`, `importlib_metadata`
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes sagemath#1337" -->
Resolves sagemath#34831
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
URL: sagemath#35203
Reported by: Matthias Köppe
Reviewer(s): Tobias Diez
…so sage-cleaner won't kill random processes
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
From sagemath#27769:
Under rare conditions, sage is killed at startup by sage-cleaner.
This requires:
Files left over in ~/.sage/temp/HOSTNAME/PID
A pid in ~/.sage/temp/HOSTNAME/PID/spawned_processes must exist, and
be started at init time. Its process group id will be 0
When sage-cleaner tries to clean up, it will do a "kill 0", which will
kill sage.
Files will only be left in ~/.sage/temp/HOSTNAME if sage is not shutdown
properly. Most likely because of a reboot.
Even if the situation doesn't result on a "kill 0", sage-cleaner would
still go on a killing spree for random processes which is awful.
The current PR removes everything under ~/.sage/temp/HOSTNAME/ at sage-
cleaner startup so this doesn't happen.
Since sage-cleaner won't run more than once at a time, this seems safe.
Fixes sagemath#27769
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes sagemath#1337" -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
URL: sagemath#35204
Reported by: Gonzalo Tornaría
Reviewer(s):
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description This removes the deprecations introduced in sagemath#18940. So the only allowed slicing of polynomials is `p[:k]`. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes sagemath#1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have linked an issue or discussion. - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: sagemath#35205 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Matthias Köppe
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description This removes most instances of pycodestyle warning E502 the backslash is redundant between brackets inside pyx files. There remains only a few in rings/, that could be easily fixed when activiting the check in the linter. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes sagemath#1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [ ] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: sagemath#35206 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
…o rings/improve_lazy_shift
…rings/improve_lazy_shift
|
Merge conflict |
|
Trivial rebase. |
|
This has broken the linter by introducing empty EXAMPLES blocks (and also changed 340 files..) |
|
maybe you did not intend to include this "key tableaux crystals" ? for the fix see #35418 |
|
This commit absolutely does not belong to this ticket. I must say that I do not understand the notification above with the commit - it says "release manager" |
|
Indeed, that file/commit should not have been included. Because the GH diff doesn't work no matter how I do the merge locally (which I had to do because of the conflict), it didn't display what actually changed from |
|
Should it be removed again, and if so, would that be possible? |
|
I have removed the file in #35418 |
|
@fchapoton Thank you. Sorry about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This address the arity problem noted in #35261. It also removes a
TODOin arevert()implementation by making the behavior the same across different implementations. Warnings are added for the user for the assumptions made by the code.📝 Checklist
⌛ Dependencies
sage/data_structures/stream.py#35127 Avoiding a long test.src/sage/rings/lazy_series.py#35254 Avoiding merge conflicts.__getitem__.