Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated slicing semantics of polynomials #35205

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 26, 2023

📚 Description

This removes the deprecations introduced in #18940. So the only allowed slicing of polynomials is p[:k].

📝 Checklist

  • I have linked an issue or discussion.
  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Patch coverage: 98.01% and project coverage change: +0.01 🎉

Comparison is base (52a81cb) 88.57% compared to head (75e3f31) 88.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35205      +/-   ##
===========================================
+ Coverage    88.57%   88.59%   +0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397406     +133     
===========================================
+ Hits        351891   352081     +190     
+ Misses       45382    45325      -57     
Impacted Files Coverage Δ
src/sage/schemes/elliptic_curves/ell_generic.py 93.25% <66.66%> (+0.01%) ⬆️
src/sage/interfaces/tachyon.py 87.93% <90.00%> (+0.43%) ⬆️
src/sage/schemes/elliptic_curves/gal_reps.py 82.23% <90.00%> (+0.04%) ⬆️
src/sage/quadratic_forms/quadratic_form.py 90.26% <95.65%> (+0.16%) ⬆️
src/sage/modular/quasimodform/element.py 99.20% <100.00%> (+0.06%) ⬆️
...l/padics/polynomial_padic_capped_relative_dense.py 67.91% <100.00%> (-0.06%) ⬇️
...age/rings/polynomial/polynomial_element_generic.py 92.14% <100.00%> (+0.12%) ⬆️
src/sage/rings/qqbar.py 95.30% <100.00%> (+<0.01%) ⬆️
src/sage/schemes/affine/affine_morphism.py 90.33% <100.00%> (ø)
src/sage/schemes/elliptic_curves/BSD.py 43.75% <100.00%> (+0.21%) ⬆️
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fchapoton
Copy link
Contributor Author

ok, changed the error to IndexError

@mkoeppe mkoeppe changed the title remove deprecations about slicing polynomials remove deprecated slicing semantics of polynomials Mar 6, 2023
@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 6, 2023

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 75e3f31

@vbraun vbraun merged commit 77a0c34 into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
@fchapoton fchapoton deleted the remove_deprecation_18940 branch July 16, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants