Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to tangent vectors #35189

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Conversation

tobiasdiez
Copy link
Contributor

📚 Description

Add typing information for tangent vectors (and related classes).

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 88.58% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (00b3cba) compared to base (c017a6a).
Patch coverage: 77.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35189      +/-   ##
===========================================
- Coverage    88.58%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397293      +20     
===========================================
+ Hits        351933   351936       +3     
- Misses       45340    45357      +17     
Impacted Files Coverage Δ
src/sage/manifolds/differentiable/tensorfield.py 86.37% <50.00%> (-0.11%) ⬇️
src/sage/manifolds/differentiable/scalarfield.py 93.45% <66.66%> (ø)
src/sage/manifolds/differentiable/diff_map.py 85.28% <75.00%> (-0.44%) ⬇️
src/sage/tensor/modules/free_module_element.py 90.47% <75.00%> (-9.53%) ⬇️
src/sage/manifolds/differentiable/tangent_space.py 95.83% <83.33%> (-1.23%) ⬇️
src/sage/tensor/modules/free_module_morphism.py 86.15% <83.33%> (-0.18%) ⬇️
src/sage/tensor/modules/free_module_tensor.py 91.55% <85.71%> (-0.14%) ⬇️
src/sage/categories/super_modules_with_basis.py 96.29% <0.00%> (-3.71%) ⬇️
...rc/sage/categories/super_lie_conformal_algebras.py 95.00% <0.00%> (-1.67%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-1.58%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 00b3cba

Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@tobiasdiez
Copy link
Contributor Author

Thanks for the review!

@vbraun vbraun merged commit c140569 into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
@tobiasdiez tobiasdiez deleted the typing_tangentvector branch March 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants