Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symmetrica needs to have its deallocation routine called upon exit #891

Closed
mwhansen opened this issue Oct 13, 2007 · 1 comment
Closed

symmetrica needs to have its deallocation routine called upon exit #891

mwhansen opened this issue Oct 13, 2007 · 1 comment
Assignees
@mwhansen
Labels
p: major / 3 t: bug
Milestone
sage-2.8.7

Comments

@mwhansen
Copy link
Contributor

Component: memleak

Issue created by migration from https://trac.sagemath.org/ticket/891
@mwhansen mwhansen added this to the sage-2.8.7 milestone Oct 13, 2007
@mwhansen mwhansen self-assigned this Oct 13, 2007
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 13, 2007

comment:1

Attachment: 6720.patch.gz

Here are some statistics: The really big one is

==26643== 80,000 bytes in 1 blocks are still reachable in loss record 1,797 of 1,866
==26643==    at 0x4A1BB35: malloc (vg_replace_malloc.c:207)
==26643==    by 0xDFD414A: SYM_malloc (in /tmp/Work-mabshoff/sage-2.8.7-alpha0/devel/sage-main/build/sage/libs/symmetrica/sy
mmetrica.so)
==26643==    by 0xDFD4219: anfang (in /tmp/Work-mabshoff/sage-2.8.7-alpha0/devel/sage-main/build/sage/libs/symmetrica/symmet
rica.so)
==26643==    by 0xDFAF13A: __pyx_f_py_10symmetrica_start (symmetrica.c:6089)
==26643==    by 0x482FE8: PyEval_EvalFrameEx (ceval.c:3548)
==26643==    by 0x484F3A: PyEval_EvalCodeEx (ceval.c:2831)
==26643==    by 0x4851D1: PyEval_EvalCode (ceval.c:494)
==26643==    by 0x49B4FE: PyImport_ExecCodeModuleEx (import.c:669)
==26643==    by 0x49BE0F: load_source_module (import.c:953)
==26643==    by 0x49C45D: import_submodule (import.c:2394)
==26643==    by 0x49C920: load_next (import.c:2214)
==26643==    by 0x49CB7D: import_module_level (import.c:2002)

But there are a bunch of smaller issues (mostly 8, 16 or 32 bytes)

Without the patch:

==26643== LEAK SUMMARY:
==26643==    definitely lost: 0 bytes in 0 blocks.
==26643==      possibly lost: 198,182 bytes in 521 blocks.
==26643==    still reachable: 34,535,836 bytes in 16,831 blocks.
==26643==         suppressed: 0 bytes in 0 blocks.

With the patch:

==26449== LEAK SUMMARY:
==26449==    definitely lost: 0 bytes in 0 blocks.
==26449==      possibly lost: 198,654 bytes in 522 blocks.
==26449==    still reachable: 34,454,092 bytes in 16,785 blocks.
==26449==         suppressed: 0 bytes in 0 blocks.

Every byte counts!

Cheers,

Michael

vbraun pushed a commit that referenced this issue Mar 26, 2023
gh-35185: Bump actions/cache from 2 to 3
249f67b 
    
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/cache/releases">actions/cache's
releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>
<p>This change adds a minimum runner version(node12 -&gt; node16), which
can break users using an out-of-date/fork of the runner. This would be
most commonly affecting users on GHES 3.3 or before, as those runners do
not support node16 actions and they can use actions from github.com via
<a href="https://docs.github.com/en/[email protected]/admin/github-
actions/managing-access-to-actions-from-githubcom/enabling-automatic-
access-to-githubcom-actions-using-github-connect">github connect</a> or
manually copying the repo to their GHES instance.</p>
</li>
<li>
<p>Few dependencies and cache action usage examples have also been
updated.</p>
</li>
</ul>
<h2>v2.1.7</h2>
<p>Support 10GB cache upload using the latest version <code>1.0.8</code>
of <a href="https://www.npmjs.com/package/@actions/cache"><code>@actions
/cache</code> </a></p>
<h2>v2.1.6</h2>
<ul>
<li>Catch unhandled &quot;bad file descriptor&quot; errors that
sometimes occurs when the cache server returns non-successful response
(<a href="https://github-redirect.dependabot.com/actions/cache/pull/596"
>actions/cache#596</a>)</li>
</ul>
<h2>v2.1.5</h2>
<ul>
<li>Fix permissions error seen when extracting caches with GNU tar that
were previously created using BSD tar (<a href="https://github-redirect.
dependabot.com/actions/cache/issues/527">actions/cache#527</a>)</li>
</ul>
<h2>v2.1.4</h2>
<ul>
<li>Make caching more verbose <a href="https://github-
redirect.dependabot.com/actions/toolkit/pull/650">#650</a></li>
<li>Use GNU tar on macOS if available <a href="https://github-
redirect.dependabot.com/actions/toolkit/pull/701">#701</a></li>
</ul>
<h2>v2.1.3</h2>
<ul>
<li>Upgrades <code>@actions/core</code> to v1.2.6 for <a
href="https://github.com/advisories/GHSA-
mfwh-5m23-j46w">CVE-2020-15228</a>. This action was not using the
affected methods.</li>
<li>Fix error handling in <code>uploadChunk</code> where 400-level
errors were not being detected and handled correctly</li>
</ul>
<h2>v2.1.2</h2>
<ul>
<li>Adds input to limit the chunk upload size, useful for self-hosted
runners with slower upload speeds</li>
<li>No-op when executing on GHES</li>
</ul>
<h2>v2.1.1</h2>
<ul>
<li>Update <code>@actions/cache</code> package to <code>v1.0.2</code>
which allows cache action to use posix format when taring files.</li>
</ul>
<h2>v2.1.0</h2>
<ul>
<li>Replaces the <code>http-client</code> with the Azure Storage SDK for
NodeJS when downloading cache content from Azure.  This should help
improve download performance and reliability as the SDK downloads files
in 4 MB chunks, which can be parallelized and retried independently</li>
<li>Display download progress and speed</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/
RELEASES.md">actions/cache's changelog</a>.</em></p>
<blockquote>
<h1>Releases</h1>
<h3>3.0.0</h3>
<ul>
<li>Updated minimum runner version support from node 12 -&gt; node
16</li>
</ul>
<h3>3.0.1</h3>
<ul>
<li>Added support for caching from GHES 3.5.</li>
<li>Fixed download issue for files &gt; 2GB during restore.</li>
</ul>
<h3>3.0.2</h3>
<ul>
<li>Added support for dynamic cache size cap on GHES.</li>
</ul>
<h3>3.0.3</h3>
<ul>
<li>Fixed avoiding empty cache save when no files are available for
caching. (<a href="https://github-
redirect.dependabot.com/actions/cache/issues/624">issue</a>)</li>
</ul>
<h3>3.0.4</h3>
<ul>
<li>Fixed tar creation error while trying to create tar with path as
<code>~/</code> home folder on <code>ubuntu-latest</code>. (<a
href="https://github-
redirect.dependabot.com/actions/cache/issues/689">issue</a>)</li>
</ul>
<h3>3.0.5</h3>
<ul>
<li>Removed error handling by consuming actions/cache 3.0 toolkit, Now
cache server error handling will be done by toolkit. (<a
href="https://github-
redirect.dependabot.com/actions/cache/pull/834">PR</a>)</li>
</ul>
<h3>3.0.6</h3>
<ul>
<li>Fixed <a href="https://github-
redirect.dependabot.com/actions/cache/issues/809">#809</a> - zstd -d: no
such file or directory error</li>
<li>Fixed <a href="https://github-
redirect.dependabot.com/actions/cache/issues/833">#833</a> - cache
doesn't work with github workspace directory</li>
</ul>
<h3>3.0.7</h3>
<ul>
<li>Fixed <a href="https://github-
redirect.dependabot.com/actions/cache/issues/810">#810</a> - download
stuck issue. A new timeout is introduced in the download process to
abort the download if it gets stuck and doesn't finish within an
hour.</li>
</ul>
<h3>3.0.8</h3>
<ul>
<li>Fix zstd not working for windows on gnu tar in issues <a
href="https://github-
redirect.dependabot.com/actions/cache/issues/888">#888</a> and <a
href="https://github-
redirect.dependabot.com/actions/cache/issues/891">#891</a>.</li>
<li>Allowing users to provide a custom timeout as input for aborting
download of a cache segment using an environment variable
<code>SEGMENT_DOWNLOAD_TIMEOUT_MINS</code>. Default is 60 minutes.</li>
</ul>
<h3>3.0.9</h3>
<ul>
<li>Enhanced the warning message for cache unavailablity in case of
GHES.</li>
</ul>
<h3>3.0.10</h3>
<ul>
<li>Fix a bug with sorting inputs.</li>
<li>Update definition for restore-keys in README.md</li>
</ul>
<h3>3.0.11</h3>
<ul>
<li>Update toolkit version to 3.0.5 to include
<code>@actions/core@^1.10.0</code></li>
<li>Update <code>@actions/cache</code> to use updated
<code>saveState</code> and <code>setOutput</code> functions from
<code>@actions/core@^1.10.0</code></li>
</ul>
<h3>3.1.0-beta.1</h3>
<ul>
<li>Update <code>@actions/cache</code> on windows to use gnu tar and
zstd by default and fallback to bsdtar and zstd if gnu tar is not
available. (<a href="https://github-
redirect.dependabot.com/actions/cache/issues/984">issue</a>)</li>
</ul>
<h3>3.1.0-beta.2</h3>
<ul>
<li>Added support for fallback to gzip to restore old caches on
windows.</li>
</ul>
<h3>3.1.0-beta.3</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="actions/cache@69d9d449aced6a2ede0
bc19182fadc3a0a42d2b0"><code>69d9d44</code></a> Merge pull request <a
href="https://github-
redirect.dependabot.com/actions/cache/issues/1118">#1118</a> from
actions/pdotl/zstd-hotfix</li>
<li><a href="actions/cache@8d3a1e02aa504540dff
5000c782b8263e3b411fb"><code>8d3a1e0</code></a> Fix license</li>
<li><a href="actions/cache@b1db4b48979ec1f6d61
42513d9448c4288d05ec4"><code>b1db4b4</code></a> Fix zstd breaking after
new version release</li>
<li><a href="actions/cache@7d4d6f7ffd301005e7f
ac90369bb90ae1d547974"><code>7d4d6f7</code></a> Update package-
lock.json</li>
<li><a href="actions/cache@8f7fa5d715f6773b40e
9fbf9cb77bcb5d914d0dc"><code>8f7fa5d</code></a> Bump
<code>@​actions/cache</code> version</li>
<li><a href="actions/cache@95b455a0fba5a5e1770
cc10ded51e5fe99a6737b"><code>95b455a</code></a> 3.2.6</li>
<li><a href="actions/cache@81b728193625a15a55f
cce4c6eb6187358533785"><code>81b7281</code></a> Updated branch in Force
deletion of caches (<a href="https://github-
redirect.dependabot.com/actions/cache/issues/1108">#1108</a>)</li>
<li><a href="actions/cache@6998d139ddd3e68c71e
9e398d8e40b71a2f39812"><code>6998d13</code></a> Release patch version
update (<a href="https://github-
redirect.dependabot.com/actions/cache/issues/1105">#1105</a>)</li>
<li><a href="actions/cache@2b8105bdae4b746666e
e225970c4a281bbd9d51f"><code>2b8105b</code></a> Fixing paths for OSes
(<a href="https://github-
redirect.dependabot.com/actions/cache/issues/1101">#1101</a>)</li>
<li><a href="actions/cache@e08330827dd5663b268
018076572bea59a734b60"><code>e083308</code></a> Fixed typos and
formatting in docs (<a href="https://github-
redirect.dependabot.com/actions/cache/issues/1076">#1076</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/cache/compare/v2...v3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-
badges.githubapp.com/badges/compatibility_score?dependency-
name=actions/cache&package-manager=github_actions&previous-
version=2&new-version=3)](https://docs.github.com/en/github/managing-
security-vulnerabilities/about-dependabot-security-updates#about-
compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
    
URL: #35185
Reported by: dependabot[bot]
Reviewer(s): Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwhansen mwhansen

Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.8.7
Development

No branches or pull requests
2 participants
@mwhansen @williamstein