Modify icon() function to call fontawesome::fa_i() for equivalent functionality
#3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
reviewed
Feb 19, 2021
wch
reviewed
Feb 19, 2021
wch
reviewed
Feb 19, 2021
wch
reviewed
Feb 19, 2021
wch
reviewed
Feb 19, 2021
|
@rich-iannone the unit tests are failing because some of the tabset panel logic relies on this behavior: > cat(as.character(icon(NULL)))
<i class="" role="presentation" aria-label=" icon"></i>We should probably do an early return for that case... |
|
Thanks @cpsievert , didn't know about that one and was puzzled by the CI results. I've pushed a change based on your recommendation. |
cpsievert
reviewed
May 6, 2021
wch
reviewed
May 11, 2021
|
Would it be possible to get the |
Yea, but I'm not sure I want to allow |
wch
approved these changes
May 12, 2021
schloerke
added a commit
that referenced
this pull request
May 17, 2021
* master: (48 commits) Modify `icon()` function to call `fontawesome::fa_i()` for equivalent functionality (#3302) Follow up to #3372: fix oversight in refactor (#3387) Revert "Do not double pull within rituals" Do not double pull within rituals Remove deprecated code and parameters (#3137) Prettify TS Rebuild JS files Add important flag Update comments Add sendImageSize2 Use removeSheet() Make more CSS properties !important Add note about synchronous behavior in IE Rebuild JS files Simplify IE CSS handling New strategy for sending information when CSS loads Make sure dev version of rlang is available (#3382) Reduce complexity and 'black-boxed' nature of tab panel logic (#3372) Install dev version of rlang (#3379) Comment about the hoisting ...
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the dependency files for Font Awesome icon support (font files, CSS, JS) over to the fontawesome package and modifies the
shiny::icon()function so that it callsfontawesome::fa_i()to generate the<i>tag object. Other scripts that create supporting Font Awesome objects have been moved over to the fontawesome package and are removed here.The fontawesome package has been placed in
ImportsandRemotes(for now, due to be in CRAN shortly). Manual testing has been done using this branch and the release candidate of fontawesome. The demo app138-icon-fontawesomeworks with these builds.