Reduce complexity and 'black-boxed' nature of tab panel logic #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
reviewed
Apr 27, 2021
wch
reviewed
Apr 27, 2021
wch
approved these changes
May 3, 2021
1 task
|
I believe that |
You're right. I checked with Barret and it should preserve HTML attribute order (it doesn't preserve ordering of the I was getting confused by the fact that, in the old behavior, active vs non-active tabs will have different ordering of their attributes. If you think it's important we maintain that (inconsistent) ordering, I can do it, but it'll introduce more complexity |
wch
approved these changes
May 5, 2021
This comment has been minimized.
This comment has been minimized.
cpsievert
added a commit
that referenced
this pull request
May 10, 2021
cpsievert
added a commit
that referenced
this pull request
May 10, 2021
schloerke
added a commit
that referenced
this pull request
May 17, 2021
* master: (48 commits) Modify `icon()` function to call `fontawesome::fa_i()` for equivalent functionality (#3302) Follow up to #3372: fix oversight in refactor (#3387) Revert "Do not double pull within rituals" Do not double pull within rituals Remove deprecated code and parameters (#3137) Prettify TS Rebuild JS files Add important flag Update comments Add sendImageSize2 Use removeSheet() Make more CSS properties !important Add note about synchronous behavior in IE Rebuild JS files Simplify IE CSS handling New strategy for sending information when CSS loads Make sure dev version of rlang is available (#3382) Reduce complexity and 'black-boxed' nature of tab panel logic (#3372) Install dev version of rlang (#3379) Comment about the hoisting ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(To be merged after rstudio/htmltools#215)
In #3315, a lot of complexity was added to
buildTabset()(and the JS behindinsertTab(), etc) due to this Bootstrap 4+ regression (at the time, I thought it was a "known" regression, but apparently it was an oversight). That regression has already been fixed in{bslib}'sversion = 4(via rstudio/bslib#306), hence the bump in{bslib}'s version requirement.