Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #3372: fix oversight in refactor #3387

Merged
merged 1 commit into from
May 10, 2021
Merged

Follow up to #3372: fix oversight in refactor #3387

merged 1 commit into from
May 10, 2021

Conversation

cpsievert
Copy link
Collaborator

Fixes #3386

@cpsievert cpsievert requested a review from schloerke May 10, 2021 14:45
schloerke
schloerke approved these changes May 10, 2021
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reverted the change made in Rituals.yaml that will fix it. No need to merge if you don't want to.

@cpsievert cpsievert merged commit 383fa6c into master May 10, 2021
@cpsievert cpsievert deleted the tab-panel-fix branch May 10, 2021 14:58
schloerke added a commit that referenced this pull request May 17, 2021
@schloerke
Merge branch 'master' into barret/ts_iteration_2
5bca84e 
* master: (48 commits)
  Modify `icon()` function to call `fontawesome::fa_i()` for equivalent functionality (#3302)
  Follow up to #3372: fix oversight in refactor (#3387)
  Revert "Do not double pull within rituals"
  Do not double pull within rituals
  Remove deprecated code and parameters (#3137)
  Prettify TS
  Rebuild JS files
  Add important flag
  Update comments
  Add sendImageSize2
  Use removeSheet()
  Make more CSS properties !important
  Add note about synchronous behavior in IE
  Rebuild JS files
  Simplify IE CSS handling
  New strategy for sending information when CSS loads
  Make sure dev version of rlang is available (#3382)
  Reduce complexity and 'black-boxed' nature of tab panel logic (#3372)
  Install dev version of rlang (#3379)
  Comment about the hoisting
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console error when adding Foo tab
2 participants
@cpsievert @schloerke