Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code and parameters #3137

Merged
merged 8 commits into from
May 6, 2021
Merged

Remove deprecated code and parameters #3137

merged 8 commits into from
May 6, 2021

Conversation

wch
Copy link
Collaborator

@wch wch commented Nov 10, 2020

This PR removes some old deprecated functions and parameters

@wch wch requested a review from schloerke November 10, 2020 20:03
@wch wch force-pushed the wch-rm-deprecated branch from af7edb2 to a1e79e8 Compare November 10, 2020 22:00
@schloerke schloerke added this to the 1.7 milestone Feb 11, 2021
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do about the unit tests that want to use extractStackTrace()

@cpsievert cpsievert merged commit 2360bde into master May 6, 2021
@cpsievert cpsievert deleted the wch-rm-deprecated branch May 6, 2021 14:46
rich-iannone added a commit that referenced this pull request May 6, 2021
* master: (23 commits)
  Remove deprecated code and parameters (#3137)
  Prettify TS
  Rebuild JS files
  Add important flag
  Update comments
  Add sendImageSize2
  Use removeSheet()
  Make more CSS properties !important
  Add note about synchronous behavior in IE
  Rebuild JS files
  Simplify IE CSS handling
  New strategy for sending information when CSS loads
  Make sure dev version of rlang is available (#3382)
  Comment about the hoisting
  Use sendImageSize instead of Shiny.bindAll to resend CSS info
  remove logs
  Poll every 0.1sec for 10secs
  request on next tick
  try using requestAnimationFrame
  Try sending multiple times
  ...
schloerke added a commit that referenced this pull request May 17, 2021
* master: (48 commits)
  Modify `icon()` function to call `fontawesome::fa_i()` for equivalent functionality (#3302)
  Follow up to #3372: fix oversight in refactor (#3387)
  Revert "Do not double pull within rituals"
  Do not double pull within rituals
  Remove deprecated code and parameters (#3137)
  Prettify TS
  Rebuild JS files
  Add important flag
  Update comments
  Add sendImageSize2
  Use removeSheet()
  Make more CSS properties !important
  Add note about synchronous behavior in IE
  Rebuild JS files
  Simplify IE CSS handling
  New strategy for sending information when CSS loads
  Make sure dev version of rlang is available (#3382)
  Reduce complexity and 'black-boxed' nature of tab panel logic (#3372)
  Install dev version of rlang (#3379)
  Comment about the hoisting
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants