-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code and parameters #3137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
force-pushed
the
wch-rm-deprecated
branch
from
November 10, 2020 22:00
af7edb2
to
a1e79e8
Compare
cpsievert
approved these changes
May 5, 2021
cpsievert
requested changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what to do about the unit tests that want to use extractStackTrace()
cpsievert
approved these changes
May 6, 2021
rich-iannone
added a commit
that referenced
this pull request
May 6, 2021
* master: (23 commits) Remove deprecated code and parameters (#3137) Prettify TS Rebuild JS files Add important flag Update comments Add sendImageSize2 Use removeSheet() Make more CSS properties !important Add note about synchronous behavior in IE Rebuild JS files Simplify IE CSS handling New strategy for sending information when CSS loads Make sure dev version of rlang is available (#3382) Comment about the hoisting Use sendImageSize instead of Shiny.bindAll to resend CSS info remove logs Poll every 0.1sec for 10secs request on next tick try using requestAnimationFrame Try sending multiple times ...
schloerke
added a commit
that referenced
this pull request
May 17, 2021
* master: (48 commits) Modify `icon()` function to call `fontawesome::fa_i()` for equivalent functionality (#3302) Follow up to #3372: fix oversight in refactor (#3387) Revert "Do not double pull within rituals" Do not double pull within rituals Remove deprecated code and parameters (#3137) Prettify TS Rebuild JS files Add important flag Update comments Add sendImageSize2 Use removeSheet() Make more CSS properties !important Add note about synchronous behavior in IE Rebuild JS files Simplify IE CSS handling New strategy for sending information when CSS loads Make sure dev version of rlang is available (#3382) Reduce complexity and 'black-boxed' nature of tab panel logic (#3372) Install dev version of rlang (#3379) Comment about the hoisting ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some old deprecated functions and parameters