Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navbarMenu()'s icon parameter should throw better error #3383

Closed
cpsievert opened this issue May 6, 2021 · 3 comments
Closed

navbarMenu()'s icon parameter should throw better error #3383

cpsievert opened this issue May 6, 2021 · 3 comments

Comments

@cpsievert
Copy link
Collaborator

Currently you get an unhelpful error message

library(shiny)

ui <- fluidPage(
  tabsetPanel(
    navbarMenu(
      "Foo",
      tabPanel("Bar", "bar"),
      icon = "calendar"
      #icon = icon("calendar")
    )
  )
)

shinyApp(ui, function(...) {})
#> Error in icon$attribs : $ operator is invalid for atomic vectors
@wch
Copy link
Collaborator

wch commented May 6, 2021

Did previous versions of Shiny allow a string? I'm more inclined to just provide a better error message. I'd prefer we make it flexible enough for people to use whatever kind of icons they want.

@cpsievert
Copy link
Collaborator Author

Ok, yea, I don't think so

@cpsievert cpsievert changed the title navbarMenu()'s icon parameter should allow character string navbarMenu()'s icon parameter should throw better error May 6, 2021
cpsievert added a commit that referenced this issue May 6, 2021
@cpsievert
Close #3384 and #3383: simplify and correct icon() logic
e241b11
cpsievert added a commit that referenced this issue May 12, 2021
@rich-iannone @cpsievert
Modify icon() function to call fontawesome::fa_i() for equivalent…
d65ad5e 
… functionality (#3302)

* Use `fontawesome::fa_i()` for FA <i> tags

* Remove fontawesome vendor files

* Add fontawesome pkg to Imports & Remotes

* Remove FontAwesome `person()` entry

* Remove Font Awesome license info

* Delete font-awesome.R

* Update 'Collate' field (removes 'font-awesome.R')

* Delete updateFontAwesome.R

* Prefer use of `fontawesome::fa()`

* Improve function documentation

* Update help file using roxygen

* Modify icon name

* Update icon name in example

* Modify icon name in example

* Update help files

* Update bootstrap.R

* Update icon.Rd

* Update bootstrap.R

* Revert `showcaseCodeTabs()` to use FA v4 name

* Revert icon name in example (back to FA v4)

* Remove `call. = FALSE` in `stop()`

* Remove `fontawesome` from Remotes

* Add min version req for the fontawesome pkg

* Increase minimum version requirement for fontawesome

* Update roxygen docs for `icon()`

* Document (GitHub Actions)

* Update icon.Rd

* Generate early return <i> tag for tabsetPanel logic

* Close #3384 and #3383: simplify and correct icon() logic

* Install htmltools PR for now

* Document (GitHub Actions)

* Avoid using tag attribs to hold non-attribute values

* Better legacy support

* No need to call prepTabIcon() twice

* code review

* Fix glyphicon class creation

* update news

Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: rich-iannone <[email protected]>
Co-authored-by: cpsievert <[email protected]>
@cpsievert
Copy link
Collaborator Author

Fixed via #3302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wch @cpsievert