-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non transform capabilities for intra-process #1849
Add non transform capabilities for intra-process #1849
Commits on Jan 4, 2022
-
Added test for publisher and subscription with same type adapter
Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 10795a4 - Browse repository at this point
Copy the full SHA 10795a4View commit details -
Added subscription type buffer
Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 066c79b - Browse repository at this point
Copy the full SHA 066c79bView commit details -
test_any_subscription_callback isolated test working
Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ceabc8 - Browse repository at this point
Copy the full SHA 1ceabc8View commit details -
Add in more of the necessary logic on the publish side. (#2)
That is, make sure to deal with inter-process publishing properly. This requires us to introduce two copies of do_intra_process_and_return_shared(), one of which deals with the ROS Message type and the other that deals with the PublishedType. This is kind of wasteful, and we may get rid of this later on, but this works for now. Signed-off-by: Chris Lalancette <[email protected]> Make sure to add the appropriate library directory. (#3) Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6dc5e4e - Browse repository at this point
Copy the full SHA 6dc5e4eView commit details -
Re-enable most of the rclcpp tests. (#4)
We comment out the ones that are currently giving us trouble. Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1334d33 - Browse repository at this point
Copy the full SHA 1334d33View commit details -
Revamp the IntraProcessManager publish logic.
There is no change here, the new way is just easier to read. Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for df5f52e - Browse repository at this point
Copy the full SHA df5f52eView commit details -
Push the publish conversion down to the intra-process manager (#6)
* Remove template defaults that we never use. Signed-off-by: Chris Lalancette <[email protected]> * Rename MessageT to PublishedType in the IntraProcessManager. It makes it easier to determine which type we are talking about. Signed-off-by: Chris Lalancette <[email protected]> * Get all the types setup to push the conversion down to IPM. There really is no functional change here, just preparing to move the conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <[email protected]> * Move conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54166ee - Browse repository at this point
Copy the full SHA 54166eeView commit details -
Clarify the template types (#7)
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <[email protected]> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <[email protected]> * More clarification of the types. Signed-off-by: Chris Lalancette <[email protected]> * More clarification of the types. Signed-off-by: Chris Lalancette <[email protected]> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6fb0254 - Browse repository at this point
Copy the full SHA 6fb0254View commit details -
Add required conversions to any subscription callback (#8)
* Add required conversions to any subscription callback * Style fixes for the linters. (#9) Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7925aee - Browse repository at this point
Copy the full SHA 7925aeeView commit details -
Fixed image tools issues Signed-off-by: Gonzalo de Pedro <[email protected]> Fix linting. (#12) Signed-off-by: Chris Lalancette <[email protected]> Fix the test for any_subscription_callback. (#13) In particular, change it so that the tests for TypeAdaptation with any_subscription_callback always pass the custom type to dispatch_intra_process(). That means that when using TypeAdaptation, it is not possible to call dispatch_intra_process() with the ROS message type. But since this is a low-level interface, this should be fine; the public-facing APIs handle this case for us. This also requires us to remove the test for inter-process publishing with type adaptation. That's because we didn't change the signature of AnySubscriptionCallback::dispath() to take in the custom type, so it always expects the ROS message type. Signed-off-by: Chris Lalancette <[email protected]> Reenable the test_intra_process* tests. (#14) Signed-off-by: Chris Lalancette <[email protected]> Remove debugging print statements. (#11) Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5c5504 - Browse repository at this point
Copy the full SHA a5c5504View commit details -
* Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Fixed some tests Signed-off-by: Gonzalo de Pedro <[email protected]> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <[email protected]> * Style fixups. Signed-off-by: Chris Lalancette <[email protected]> * One more small fix. Signed-off-by: Chris Lalancette <[email protected]> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <[email protected]> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <[email protected]> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <[email protected]> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <[email protected]> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 89c70d1 - Browse repository at this point
Copy the full SHA 89c70d1View commit details -
We just had to make sure there was a subscriber so that the conversion would be attempted, and then things started work. Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b76af8e - Browse repository at this point
Copy the full SHA b76af8eView commit details -
Fix intra process publisher message move bug (#19)
Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42cad32 - Browse repository at this point
Copy the full SHA 42cad32View commit details -
Fixes that came out of macOS. (#20)
Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71c3239 - Browse repository at this point
Copy the full SHA 71c3239View commit details -
Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da5f12e - Browse repository at this point
Copy the full SHA da5f12eView commit details -
Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3b7616 - Browse repository at this point
Copy the full SHA f3b7616View commit details -
Added tests for non transform intra process
Signed-off-by: Gonzalo de Pedro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3c29a57 - Browse repository at this point
Copy the full SHA 3c29a57View commit details -
Refactor the intra-process-manager to be more readable.
Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1779cd8 - Browse repository at this point
Copy the full SHA 1779cd8View commit details -
Respond to more review comments.
Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c8c4851 - Browse repository at this point
Copy the full SHA c8c4851View commit details
Commits on Jan 6, 2022
-
Rename ROSMessageIntraProcessBuffer()
To SubscriptionROSMsgIntraProcessBuffer() Signed-off-by: Chris Lalancette <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6d47368 - Browse repository at this point
Copy the full SHA 6d47368View commit details