Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non transform capabilities for intra-process #1849

Commits on Jan 4, 2022

  1. Added test for publisher and subscription with same type adapter

    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    10795a4 View commit details
    Browse the repository at this point in the history
  2. Added subscription type buffer

    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    066c79b View commit details
    Browse the repository at this point in the history
  3. test_any_subscription_callback isolated test working

    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    1ceabc8 View commit details
    Browse the repository at this point in the history
  4. Add in more of the necessary logic on the publish side. (#2)

    That is, make sure to deal with inter-process publishing properly.
    This requires us to introduce two copies of
    do_intra_process_and_return_shared(), one of which deals with the
    ROS Message type and the other that deals with the PublishedType.
    This is kind of wasteful, and we may get rid of this later on,
    but this works for now.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    Make sure to add the appropriate library directory. (#3)
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6dc5e4e View commit details
    Browse the repository at this point in the history
  5. Re-enable most of the rclcpp tests. (#4)

    We comment out the ones that are currently giving us trouble.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    1334d33 View commit details
    Browse the repository at this point in the history
  6. Revamp the IntraProcessManager publish logic.

    There is no change here, the new way is just easier to read.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    df5f52e View commit details
    Browse the repository at this point in the history
  7. Push the publish conversion down to the intra-process manager (#6)

    * Remove template defaults that we never use.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Rename MessageT to PublishedType in the IntraProcessManager.
    
    It makes it easier to determine which type we are talking about.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Get all the types setup to push the conversion down to IPM.
    
    There really is no functional change here, just preparing to
    move the conversion down to the intra-process manager.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Move conversion down to the intra-process manager.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    54166ee View commit details
    Browse the repository at this point in the history
  8. Clarify the template types (#7)

    * Rename the types so they are much more clear.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * More renaming of types in the subscription side.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * More clarification of the types.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * More clarification of the types.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Cleanup subscription_intra_process_* classes.
    
    Remove virtual methods that are redundant (since they come
    from the underlying Waitable class), and mark methods as override
    as appropriate.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6fb0254 View commit details
    Browse the repository at this point in the history
  9. Add required conversions to any subscription callback (#8)

    * Add required conversions to any subscription callback
    
    * Style fixes for the linters. (#9)
    
    Signed-off-by: Chris Lalancette <[email protected]>
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7925aee View commit details
    Browse the repository at this point in the history
  10. Fixed bugs, fixed linters

    Fixed image tools issues
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    
    Fix linting. (#12)
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    Fix the test for any_subscription_callback. (#13)
    
    In particular, change it so that the tests for TypeAdaptation
    with any_subscription_callback always pass the custom type
    to dispatch_intra_process().  That means that when using
    TypeAdaptation, it is not possible to call dispatch_intra_process()
    with the ROS message type.  But since this is a low-level
    interface, this should be fine; the public-facing APIs handle
    this case for us.
    
    This also requires us to remove the test for inter-process
    publishing with type adaptation.  That's because we didn't change
    the signature of AnySubscriptionCallback::dispath() to take
    in the custom type, so it always expects the ROS message type.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    Reenable the test_intra_process* tests. (#14)
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    Remove debugging print statements. (#11)
    
    Signed-off-by: Chris Lalancette <[email protected]>
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    a5c5504 View commit details
    Browse the repository at this point in the history
  11. Tests fix (#15)

    * Tests fix
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    
    * Tests fix
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    
    * Fixed some tests
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    
    * Fix test_intra_process_manager test.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Style fixups.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * One more small fix.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Fixed issues with allocators
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    
    * Small fix for lint_cmake.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    Co-authored-by: Chris Lalancette <[email protected]>
    
    Add additional tests for the TypeAdapt conversions (#16)
    
    * Implement skipping ROS conversion when using the const ref publish.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    * Add tests to ensure that type adaptation doesn't unnecessarily convert.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    
    fixed allocator allocate usage on intra process manager (#17)
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    
    Removed TestPublisher.conversion_exception_is_passed_up test
    
    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    89c70d1 View commit details
    Browse the repository at this point in the history
  12. Reenable disabled test. (#18)

    We just had to make sure there was a subscriber so that the conversion
    would be attempted, and then things started work.
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    b76af8e View commit details
    Browse the repository at this point in the history
  13. Fix intra process publisher message move bug (#19)

    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    42cad32 View commit details
    Browse the repository at this point in the history
  14. Fixes that came out of macOS. (#20)

    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    71c3239 View commit details
    Browse the repository at this point in the history
  15. Addressed review comments

    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    da5f12e View commit details
    Browse the repository at this point in the history
  16. Fix style issues.

    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    f3b7616 View commit details
    Browse the repository at this point in the history
  17. Added tests for non transform intra process

    Signed-off-by: Gonzalo de Pedro <[email protected]>
    Gonzalo de Pedro authored and clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    3c29a57 View commit details
    Browse the repository at this point in the history
  18. Refactor the intra-process-manager to be more readable.

    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    1779cd8 View commit details
    Browse the repository at this point in the history
  19. Respond to more review comments.

    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    c8c4851 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Rename ROSMessageIntraProcessBuffer()

    To SubscriptionROSMsgIntraProcessBuffer()
    
    Signed-off-by: Chris Lalancette <[email protected]>
    clalancette committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    6d47368 View commit details
    Browse the repository at this point in the history