Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required conversions to any subscription callback #8

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Add required conversions to any subscription callback #8

merged 2 commits into from
Dec 8, 2021

Conversation

gonzodepedro
Copy link
Owner

Signed-off-by: Gonzalo de Pedro [email protected]

clalancette
clalancette approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise generally looks good to me. I was able to compile and test things locally, with just the linters failing (we'll address that separately).

rclcpp/include/rclcpp/any_subscription_callback.hpp Outdated
}
}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra space here.

@clalancette clalancette mentioned this pull request Dec 8, 2021
Merged
Removed extra space
9188728 
Signed-off-by: Gonzalo de Pedro <[email protected]>
@gonzodepedro gonzodepedro merged commit 2708d54 into gonzo/non-transform-intra-process-working-tests Dec 8, 2021
clalancette pushed a commit that referenced this pull request Dec 17, 2021
@gonzodepedro @clalancette
Add required conversions to any subscription callback (#8)
6ab63e0 
* Add required conversions to any subscription callback

Signed-off-by: Gonzalo de Pedro <[email protected]>

* Removed extra space

Signed-off-by: Gonzalo de Pedro <[email protected]>
gonzodepedro added a commit that referenced this pull request Dec 20, 2021
@gonzodepedro
Add required conversions to any subscription callback (#8)
70453c8 
* Add required conversions to any subscription callback

* Style fixes for the linters. (#9)

Signed-off-by: Chris Lalancette <[email protected]>
clalancette pushed a commit that referenced this pull request Dec 20, 2021
@clalancette
Add required conversions to any subscription callback (#8)
89705cc 
* Add required conversions to any subscription callback

* Style fixes for the linters. (#9)

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
clalancette pushed a commit that referenced this pull request Jan 4, 2022
@clalancette
Add required conversions to any subscription callback (#8)
7925aee 
* Add required conversions to any subscription callback

* Style fixes for the linters. (#9)

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonzodepedro @clalancette