Fix the test for any_subscription_callback. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, change it so that the tests for TypeAdaptation with any_subscription_callback always pass the custom type to dispatch_intra_process(). That means that when using TypeAdaptation, it is not possible to call dispatch_intra_process() with the ROS message type. But since this is a low-level interface, this should be fine; the public-facing APIs handle this case for us. This also requires us to remove the test for inter-process publishing with type adaptation. That's because we didn't change the signature of AnySubscriptionCallback::dispath() to take in the custom type, so it always expects the ROS message type. Signed-off-by: Chris Lalancette <[email protected]>
gonzodepedro
merged commit 1f9bc22
into
gonzodepedro:gonzo/non-transform-intra-process-working-tests
clalancette
added a commit
that referenced
this pull request
Dec 17, 2021
In particular, change it so that the tests for TypeAdaptation with any_subscription_callback always pass the custom type to dispatch_intra_process(). That means that when using TypeAdaptation, it is not possible to call dispatch_intra_process() with the ROS message type. But since this is a low-level interface, this should be fine; the public-facing APIs handle this case for us. This also requires us to remove the test for inter-process publishing with type adaptation. That's because we didn't change the signature of AnySubscriptionCallback::dispath() to take in the custom type, so it always expects the ROS message type. Signed-off-by: Chris Lalancette <[email protected]>
gonzodepedro
pushed a commit
that referenced
this pull request
Dec 20, 2021
Fixed image tools issues Signed-off-by: Gonzalo de Pedro <[email protected]> Fix linting. (#12) Signed-off-by: Chris Lalancette <[email protected]> Fix the test for any_subscription_callback. (#13) In particular, change it so that the tests for TypeAdaptation with any_subscription_callback always pass the custom type to dispatch_intra_process(). That means that when using TypeAdaptation, it is not possible to call dispatch_intra_process() with the ROS message type. But since this is a low-level interface, this should be fine; the public-facing APIs handle this case for us. This also requires us to remove the test for inter-process publishing with type adaptation. That's because we didn't change the signature of AnySubscriptionCallback::dispath() to take in the custom type, so it always expects the ROS message type. Signed-off-by: Chris Lalancette <[email protected]> Reenable the test_intra_process* tests. (#14) Signed-off-by: Chris Lalancette <[email protected]> Remove debugging print statements. (#11) Signed-off-by: Chris Lalancette <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Dec 20, 2021
Fixed image tools issues Signed-off-by: Gonzalo de Pedro <[email protected]> Fix linting. (#12) Signed-off-by: Chris Lalancette <[email protected]> Fix the test for any_subscription_callback. (#13) In particular, change it so that the tests for TypeAdaptation with any_subscription_callback always pass the custom type to dispatch_intra_process(). That means that when using TypeAdaptation, it is not possible to call dispatch_intra_process() with the ROS message type. But since this is a low-level interface, this should be fine; the public-facing APIs handle this case for us. This also requires us to remove the test for inter-process publishing with type adaptation. That's because we didn't change the signature of AnySubscriptionCallback::dispath() to take in the custom type, so it always expects the ROS message type. Signed-off-by: Chris Lalancette <[email protected]> Reenable the test_intra_process* tests. (#14) Signed-off-by: Chris Lalancette <[email protected]> Remove debugging print statements. (#11) Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Gonzalo de Pedro <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jan 4, 2022
Fixed image tools issues Signed-off-by: Gonzalo de Pedro <[email protected]> Fix linting. (#12) Signed-off-by: Chris Lalancette <[email protected]> Fix the test for any_subscription_callback. (#13) In particular, change it so that the tests for TypeAdaptation with any_subscription_callback always pass the custom type to dispatch_intra_process(). That means that when using TypeAdaptation, it is not possible to call dispatch_intra_process() with the ROS message type. But since this is a low-level interface, this should be fine; the public-facing APIs handle this case for us. This also requires us to remove the test for inter-process publishing with type adaptation. That's because we didn't change the signature of AnySubscriptionCallback::dispath() to take in the custom type, so it always expects the ROS message type. Signed-off-by: Chris Lalancette <[email protected]> Reenable the test_intra_process* tests. (#14) Signed-off-by: Chris Lalancette <[email protected]> Remove debugging print statements. (#11) Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Gonzalo de Pedro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, change it so that the tests for TypeAdaptation
with any_subscription_callback always pass the custom type
to dispatch_intra_process(). That means that when using
TypeAdaptation, it is not possible to call dispatch_intra_process()
with the ROS message type. But since this is a low-level
interface, this should be fine; the public-facing APIs handle
this case for us.
This also requires us to remove the test for inter-process
publishing with type adaptation. That's because we didn't change
the signature of AnySubscriptionCallback::dispath() to take
in the custom type, so it always expects the ROS message type.
Signed-off-by: Chris Lalancette [email protected]