Add additional tests for the TypeAdapt conversions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
|
Hold off on this PR for now. With this in place, |
gonzodepedro
merged commit 7996d43
into
gonzodepedro:gonzo/non-transform-intra-process-working-tests
clalancette
added a commit
that referenced
this pull request
Dec 17, 2021
* Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <[email protected]> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <[email protected]>
gonzodepedro
added a commit
that referenced
this pull request
Dec 20, 2021
* Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Fixed some tests Signed-off-by: Gonzalo de Pedro <[email protected]> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <[email protected]> * Style fixups. Signed-off-by: Chris Lalancette <[email protected]> * One more small fix. Signed-off-by: Chris Lalancette <[email protected]> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <[email protected]> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <[email protected]> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <[email protected]> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <[email protected]> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Fixed some tests Signed-off-by: Gonzalo de Pedro <[email protected]> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <[email protected]> * Style fixups. Signed-off-by: Chris Lalancette <[email protected]> * One more small fix. Signed-off-by: Chris Lalancette <[email protected]> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <[email protected]> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <[email protected]> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <[email protected]> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <[email protected]> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Tests fix Signed-off-by: Gonzalo de Pedro <[email protected]> * Fixed some tests Signed-off-by: Gonzalo de Pedro <[email protected]> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <[email protected]> * Style fixups. Signed-off-by: Chris Lalancette <[email protected]> * One more small fix. Signed-off-by: Chris Lalancette <[email protected]> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <[email protected]> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <[email protected]> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <[email protected]> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <[email protected]> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests ensure that type adaptation doesn't unnecessarily happen. While writing these tests I found a bug where we weren't skipping the type adaptation with the const ref publish() method, which this also fixes.