Update to rspec3 #204
Update to rspec3 #204
Conversation
|
👍 |
|
when will this PR be merged? We are looking forward to this functionality :) |
|
@kdimiche ask @rodjek or @jeffmccune! |
|
In my opinion, this PR should be not get merged yet, as rspec3 is too recent. |
Can you try that sentence again? I can't understand what you mean. You're free not to upgrade to a new release. However not merging code that's the current way forward based on that argument seems like a bad idea. |
|
I mean, that I would like to be able to use features from current & future pull request. And I'm just stating that these changes shouldn't be accepteded yet, obviously in my opinion, because moving into a two months old backward incompatible version is not a good idea, again in my opinion, but not because I have doubts about rspec3 but because not everyone lives on the edge (I have no chance to install rspec3 on our CI system). |
This conversion is done by Transpec 2.2.1 with the following command:
transpec
* 58 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 21 conversions
from: obj.should
to: expect(obj).to
* 11 conversions
from: be_false
to: be_falsey
* 6 conversions
from: be_true
to: be_truthy
* 6 conversions
from: it { should_not ... }
to: it { is_expected.not_to ... }
For more details: https://github.com/yujinakayama/transpec#supported-conversions
…exclude unsupported combination)
doc75
force-pushed
the
update-to-rspec3
branch
from
ae2f183
to
858fb03
Compare
|
Last commit is just a rebase on current master branch. |
|
rspec 2/3 compatibility is already done in #225 |
|
I'll check if the master works fine on my rspec3 projects and close this PR if everything is OK. I just hope that @rodjek will soon publish a new version of the gem. |
|
@rodjek Any estimate on when the new gem version might be available? I'm eager to get rid of the deprecation messages from rspec3 :) |
|
Current code seems to be compatibe with RSpec 3 (but it uses RSpec 2.99 as far as I understand). |
This PR is the migration of rspec-puppet te be compliant with RSpec 3.
WARNING it is not anymore compatible with RSpec2 versions, therefore it has to be decided it is time to merge it or not.
I tested it over all the personal modules I have and everything went smooth with this version and RSpec3 (only some minor update in the test suite were made)