Cobertura reports #219
Closed
Cobertura reports #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requires the 'coveralls' gem - Reports lines that have created a resource that has been asserted
Keep the module name and filter out the manifest path portion. This allows for package alike classification, and avoids that files in the report get overwritten, leading for a single entry for 'manifest/init.pp' despite the number of modules covered.
The coverage class used the Singleton mixin which prevented creation of instances of the including class. Unsurprisingly this can make testing classes including Singleton very hard to test. This commit refactors the coverage class to have a class level `instance` method that conforms to the same interface as Singleton, but also allows instances of the class to be created. It also adds a preliminary level of test coverage so that the behavior of the class can be verified by more than just smoke and unicorn dreams.
Conflicts: lib/rspec-puppet/coverage.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements cobertura reports compatible at least with the Jenkins cobertura plugin. It is based on work from #214.
I have verified that all the tests succeed merging either #204 or #201