Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incompatibility with RSpec 3.0.0 #201

Merged
merged 1 commit into from
Sep 23, 2014

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Jun 2, 2014

Same solution as #199 but also pins rspec-puppet to RSpec < 3.0.0 as there are likely numerous other issues people will face when depending on rspec-puppet to pull in the necessary rspec dependencies.

* Fix deprecation warnings related to 'display_name', fixes rodjek#198
@030
Copy link

030 commented Jun 4, 2014

I have cloned the repo, implemented your changes, built and installed the gem and now the rspec tests work again. Thank you.

sudo rspec
...

Finished in 0.25638 seconds
3 examples, 0 failures

Total resources: 3
Touched resources: 3
Resource coverage: 100.00%

@doc75
Copy link
Contributor

doc75 commented Jun 4, 2014

When I use this version, the bundle update install rspec version 3.0.0.rc1 and it still break.
Anyone knowing a way to force really a version lower to 3.0 (even rc) ?

@hunner
Copy link
Collaborator

hunner commented Jun 9, 2014

I don't think rspec-puppet depends on rspec 2, does it?

If your rspec-puppet test use rspec 2 syntax, then you should be pinning to rspec 2.

@hunner
Copy link
Collaborator

hunner commented Jun 9, 2014

@doc75 You can add a Gemfile to your module's path and use bundler to use rspec 2. Your Gemfile should list gem 'rspec-puppet' and gem 'rspec', '~> 2.0' to get rspec 2, and then bundle install && bundle exec rake spec

@doc75
Copy link
Contributor

doc75 commented Jun 9, 2014

@hunner: You are right. But indeed, I did not force my test to use RSpec2 and that it why this pull request does not force it either as it takes 3.0.0.rc1
I could have forced my test to use only RSpec2, but the effort to move to RSpec3 was quite low in my case.

BTW, I created PR #204 to make rspec-puppet compliant with RSpec3.
0

@daenney daenney mentioned this pull request Jun 9, 2014
This was referenced Aug 4, 2014
rodjek pushed a commit that referenced this pull request Sep 23, 2014
Fixes incompatibility with RSpec 3.0.0
@rodjek rodjek merged commit c00b64c into rodjek:master Sep 23, 2014
@rodjek rodjek added this to the 2.0.0 milestone Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants