Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for Coveralls reports #214

Closed
wants to merge 1 commit into from
Closed

Add basic support for Coveralls reports #214

wants to merge 1 commit into from

Conversation

raphink
Copy link
Contributor

@raphink raphink commented Jul 21, 2014

Note:

  • Requires the 'coveralls' gem
  • Reports lines that have created a resource that has been asserted

This might look a bit weird in coveralls, because this is not what is usually reported by coverage, but I'm just building on top of what coverage support in rspec-puppet currently does, which is reporting resources that were declared but not tested (vs resources that were never declared when parsing the code, which is what is traditionally done).

An example of coveralls output can be found at https://coveralls.io/r/raphink/puppet-lvm

  - Requires the 'coveralls' gem
  - Reports lines that have created a resource that has been asserted
@petems
Copy link
Contributor

petems commented Aug 4, 2014

This is pretty awesome! 👍

@javiplx javiplx mentioned this pull request Aug 9, 2014
@raphink
Copy link
Contributor Author

raphink commented Oct 16, 2014

Any news on that?

@DavidS
Copy link
Collaborator

DavidS commented Jul 30, 2015

@raphink
Copy link
Contributor Author

raphink commented Aug 4, 2015

@DavidS I'm a bit frustrated with all coverage PRs (including mine) bth. They are not really coverage tests. They test if there has been an assertion on each resource in the catalog, which is a bit overkill, and not really the point of coverage in the first place.

I'm afraid though that the current state of the Puppet language will not let us plug in and retrieve real coverage info (as in, which percentage of code has actually been traversed/branched in).

@kylog
Copy link

kylog commented Aug 4, 2015

@raphink this is no immediate help but just as an FYI: we started thinking through how we would add coverage to the Puppet code. There's an initial epic here: https://tickets.puppetlabs.com/browse/PUP-4764.

@raphink
Copy link
Contributor Author

raphink commented Aug 4, 2015

Very cool @kylog, looking forward to this. In the meanwhile, I'm wondering if the current efforts here are really worth it.

@rodjek rodjek closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants