Add basic beaker tests

[danieldreier]

Tests only cover basic installs of standalone, passenger, and unicorn puppetmasters, as well as a very basic agent install. Minimal validation that they're working.

I'll add more tests later, just wanted to get the most rudimentary coverage in for now. Basic instructions on running the tests are added in the new CONTRIBUTING.md file.

[igalic]

surprised acceptance tests are failing, despite fb55f00

[danieldreier]

Oops. I'll have to experiment with this more tomorrow because I haven't been able to reproduce the problem outside of travis so far.

[danieldreier]

The issue turns out to be unrelated to the beaker tests. Rspec 3 came out, which broke the existing rspec-puppet tests. I restricted the rspec version in the gemfile to get tests working until we can update the tests to rspec 3 syntax. The reason it failed on travis and passed on my local machine was travis ignores the Gemfile.lock, which still had an older version of rspec.

[igalic]

ACK, we should still update to rspec3 as soon as we have the cycles

[danieldreier]

It looks to me like the rspec 3 incompatibility is coming from rspec-puppet. Can we merge this in for now, then update to rspec 3 as our dependencies update?

[zachfi]

I'm +1 on merging. This is an improvement on where we are at today regardless of the current supported rspec version, though I agree we should update when we can. Can I get another +1 on this?

[danieldreier]

The reason we're not at rspec 3 is because rspec-puppet and beaker-rspec don't support rspec 3 yet. The latest master version of beaker-rspec removes the rspec 2.14 runtime dependency, so we're really only waiting for PR 204) to be accepted on rspec-puppet.

I've tested our rspec-puppet tests with that PR version of rspec-puppet and all of the tests run without modification. All of the current problems come from rspec-puppet, not our tests.

I don't think we should implicitly block this PR on rspec-puppet's PR 204, because this PR is orthagonal to rspec 3 compatibility.

However, the only reason rspec tests pass on master right now is because the current release of beaker-rspec has a runtime dependency on rspec 2.14. That's been removed in the master branch of beaker-rspec, so once that's released we'll be back to failing travis tests on account of rspec-puppet not being working with rspec 3.

[danieldreier]

Rebased against current master. Also updated the acceptance spec helper to work around an issue with puppetlabs/ruby's master branch on debian/ubuntu.

[danieldreier]

I've got code ready for switching from ploperations/puppetlabs_apt to the standard puppetlabs/apt module, and code mostly done for switching to the jfryman/nginx module, but I'm blocking on getting the beaker tests merged in first because of the relatively high chance of those changes breaking things.

[zachfi]

Well, the ploperations/puppetlabs_apt is for installing the repo, it actually uses the puppetlabs/apt module under the hood.

As for this test suit, I suppose I'll need to learn beaker in order to make meaningful contributions again.

[danieldreier]

Thanks! Appreciate the merge. I think there's value in maintaining the rspec-puppet tests as well, because right now that's all that travis-ci is running.